remove stale issue #119 xfail for greedy paged-parity test#149
Merged
LxYuan0420 merged 1 commit intovllm-project:mainfrom Mar 11, 2026
Merged
Conversation
Signed-off-by: Yuan Lik Xun <lxyuan0420@gmail.com>
WindChimeRan
approved these changes
Mar 9, 2026
Collaborator
There was a problem hiding this comment.
LGTM. safe to merge. (seems like we still need @ericcurtin to merge these)
renqHIT
added a commit
to renqHIT/vllm-metal
that referenced
this pull request
Mar 13, 2026
The xfail on `test_batched_decode_matches` was added for issue vllm-project#119 (B=2 batched GEMM producing different floats than B=1). The test now passes consistently on main after recent paged kernel fixes (vllm-project#146, vllm-project#151). This follows PR vllm-project#149 which removed the same stale xfail for the greedy single-request test. Signed-off-by: Qiang <qren@integralads.com>
2 tasks
LxYuan0420
pushed a commit
that referenced
this pull request
Mar 17, 2026
…167) `test_metal_kernel_paged.py` re-implements vllm-metal internals (cache setup, prefill/decode orchestration, context management) to compare two paths. This scaffolding introduces additional complexity, making failures hard to attribute. Delete it and add its prompts to `test_paged_deterministic.py`, which does the same comparison end-to-end through the real vLLM stack against golden tokens. Related: #158 #149 #119 --------- Signed-off-by: ran <hzz5361@psu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is:
xfailontest_greedy_output_matchesthat was originally added for issue Metal paged-attention parity mismatch vs standard path #119.mainbehavior after paged-path fixes already merged.Context
Issue #119 reported token mismatch parity failures between:
Since then, two key fixes landed:
get_ops/nanobind), removing cross-framework bridge behavior from paged execution.With those changes, the old greedy mismatch from #119 no longer reproduces on
main, so the greedyxfailis stale.Verification