Skip to content

remove stale issue #119 xfail for greedy paged-parity test #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LxYuan0420 merged 1 commit into from
Mar 11, 2026
Merged

remove stale issue #119 xfail for greedy paged-parity test #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/test_metal_kernel_paged.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,6 @@ def qwen3_model():

class TestMetalKernelPagedVsStandard:
@pytest.mark.slow
@pytest.mark.xfail(
reason="Metal paged-attention parity mismatch vs standard path (see #119)"
)
def test_greedy_output_matches(self, qwen3_model):
"""Metal kernel paged attention greedy decode must match standard path."""
model, tokenizer = qwen3_model
Expand Down