Skip to content

[Test] Consolidate paged kernel tests into deterministic golden test#167

Merged
LxYuan0420 merged 2 commits intovllm-project:mainfrom
WindChimeRan:patch_deterministic_test
Mar 17, 2026
Merged

[Test] Consolidate paged kernel tests into deterministic golden test#167
LxYuan0420 merged 2 commits intovllm-project:mainfrom
WindChimeRan:patch_deterministic_test

Conversation

@WindChimeRan
Copy link
Collaborator

@WindChimeRan WindChimeRan commented Mar 17, 2026

test_metal_kernel_paged.py re-implements vllm-metal internals (cache setup, prefill/decode orchestration, context management) to compare two paths. This scaffolding introduces additional complexity, making failures hard to attribute.

Delete it and add its prompts to test_paged_deterministic.py, which does the same comparison end-to-end through the real vLLM stack against golden tokens.

Related:
#158
#149
#119

Signed-off-by: ran <hzz5361@psu.edu>
Signed-off-by: ran <hzz5361@psu.edu>
@WindChimeRan WindChimeRan marked this pull request as ready for review March 17, 2026 03:26
@WindChimeRan WindChimeRan requested a review from LxYuan0420 March 17, 2026 03:28
@LxYuan0420 LxYuan0420 merged commit 9ba3982 into vllm-project:main Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants