Skip to content

test(executor): tracked param integration tests (PR-04)#608

Merged
shivasurya merged 1 commit intomainfrom
shiva/querytype-integration-tests
Mar 14, 2026
Merged

test(executor): tracked param integration tests (PR-04)#608
shivasurya merged 1 commit intomainfrom
shiva/querytype-integration-tests

Conversation

@shivasurya
Copy link
Owner

Summary

15 new Go integration tests covering the full tracked parameter filtering feature:

Positive tests (should detect):

  • Positional match (taint at tracked param 0)
  • No tracks backward compat (all params sensitive)
  • Multiple tracked params (tracks(0,1))
  • Variable renamed before sink (SinkVar propagation)
  • TypeConstrainedCallIR with tracks(0)
  • Name-based tracking (tracks("query") resolves via CallGraph.Parameters)
  • Return source no-op (tracks("return") accepted, v1 no-op)
  • Positional arg constraint + tracks combined
  • Inter-proc summary filtered (global scope)

Negative tests (should NOT detect):

  • Positional reject (taint at param 1, tracked param 0)
  • Sanitized before tracked param
  • Nonexistent param name (resolves to no indices)
  • TypeConstrainedCallIR reject
  • summaryConfirmsFlow unit test with TrackedParams filtering

Edge cases:

  • Nil/mismatched CallSite line (backward compat, no TrackedParams)

Test plan

  • All 15 new TestTrackedParam_* tests pass
  • gradle buildGo passes
  • gradle testGo passes (zero regressions across all packages)
  • gradle lintGo passes (0 issues)
  • 352 Python SDK tests pass (zero regressions)

🤖 Generated with Claude Code

@shivasurya shivasurya added enhancement New feature or request go Pull requests that update go code labels Mar 14, 2026
@shivasurya shivasurya self-assigned this Mar 14, 2026
@safedep
Copy link

safedep bot commented Mar 14, 2026

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.85%. Comparing base (eb40c77) to head (7abe44e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   83.61%   83.85%   +0.24%     
==========================================
  Files         155      155              
  Lines       21030    21030              
==========================================
+ Hits        17584    17635      +51     
+ Misses       2799     2748      -51     
  Partials      647      647              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner Author

shivasurya commented Mar 14, 2026

Copy link
Owner Author

shivasurya commented Mar 14, 2026

Merge activity

  • Mar 14, 3:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 14, 3:22 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 14, 3:23 AM UTC: @shivasurya merged this pull request with Graphite.

@shivasurya shivasurya changed the base branch from shiva/querytype-executor-filtering to graphite-base/608 March 14, 2026 03:20
@shivasurya shivasurya changed the base branch from graphite-base/608 to main March 14, 2026 03:21
15 tests covering: positional match/reject, no-tracks backward compat,
multiple tracked params, variable renamed before sink, sanitized flow,
nonexistent param name, nil CallSite, TypeConstrainedCall match/reject,
name-based tracking, return source no-op, positional arg + tracks,
inter-proc summary filtered, summaryConfirmsFlow unit test with
TrackedParams filtering.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@shivasurya shivasurya force-pushed the shiva/querytype-integration-tests branch from 52d8f1c to 7abe44e Compare March 14, 2026 03:22
@github-actions
Copy link

Code Pathfinder Security Scan

Pass Critical High Medium Low Info

No security issues detected.

Metric Value
Files Scanned 1
Rules 38

Powered by Code Pathfinder

@shivasurya shivasurya merged commit c8b5f77 into main Mar 14, 2026
5 checks passed
@shivasurya shivasurya deleted the shiva/querytype-integration-tests branch March 14, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant