Skip to content

feat(executor): wire tracked param filtering (PR-03)#607

Merged
shivasurya merged 1 commit intomainfrom
shiva/querytype-executor-filtering
Mar 14, 2026
Merged

feat(executor): wire tracked param filtering (PR-03)#607
shivasurya merged 1 commit intomainfrom
shiva/querytype-executor-filtering

Conversation

@shivasurya
Copy link
Owner

Summary

  • Propagate TrackedParams through resolveMatchers() in both call_matcher and type_constrained_call branches
  • Fix MatchedCallSite nil case: look up actual CallSite from call graph when TrackedParams are present
  • Add 5 new helper functions: findCallSiteAtLine, resolveTrackedParamIndices, getParamNamesForFQN, matchesTrackedParams, resolveParamIndex
  • Filter VDG detections in executeLocal() against sink TrackedParams before appending
  • Filter inter-procedural flows in summaryConfirmsFlow() using resolveTrackedParamIndices()
  • Populate SinkParamIndex on DataflowDetection
  • Propagate SinkVar from TaintDetection to TaintInfo in AnalyzeWithVDG()
  • Tier 3 (line-proximity fallback) intentionally skips tracked param filtering per spec

Test plan

  • gradle buildGo passes
  • gradle testGo passes (zero regressions)
  • gradle lintGo passes (0 issues)
  • Empty TrackedParams = identical behavior to before (backward compat)

🤖 Generated with Claude Code

@shivasurya shivasurya added enhancement New feature or request go Pull requests that update go code labels Mar 14, 2026
@shivasurya shivasurya self-assigned this Mar 14, 2026
@safedep
Copy link

safedep bot commented Mar 14, 2026

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

Copy link
Owner Author

shivasurya commented Mar 14, 2026

Copy link
Owner Author

shivasurya commented Mar 14, 2026

Merge activity

  • Mar 14, 3:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 14, 3:20 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 14, 3:21 AM UTC: @shivasurya merged this pull request with Graphite.

@shivasurya shivasurya changed the base branch from shiva/querytype-go-ir-types-sinkvar to graphite-base/607 March 14, 2026 03:18
@shivasurya shivasurya changed the base branch from graphite-base/607 to main March 14, 2026 03:19
Propagates TrackedParams through resolveMatchers() for both call_matcher
and type_constrained_call branches. Adds helper functions:
findCallSiteAtLine, resolveTrackedParamIndices, getParamNamesForFQN,
matchesTrackedParams, resolveParamIndex. Filters VDG detections in
executeLocal() and inter-procedural flows in summaryConfirmsFlow().
Populates SinkParamIndex on DataflowDetection. Propagates SinkVar
from TaintDetection to TaintInfo in AnalyzeWithVDG.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@shivasurya shivasurya force-pushed the shiva/querytype-executor-filtering branch from f2fc9b5 to e876b18 Compare March 14, 2026 03:20
@github-actions
Copy link

Code Pathfinder Security Scan

Pass Critical High Medium Low Info

No security issues detected.

Metric Value
Files Scanned 2
Rules 38

Powered by Code Pathfinder

@shivasurya shivasurya merged commit eb40c77 into main Mar 14, 2026
5 checks passed
@shivasurya shivasurya deleted the shiva/querytype-executor-filtering branch March 14, 2026 03:21
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 39.04762% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.62%. Comparing base (ec41e05) to head (e876b18).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
sast-engine/dsl/dataflow_executor.go 38.46% 60 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   83.84%   83.62%   -0.23%     
==========================================
  Files         155      155              
  Lines       20937    21030      +93     
==========================================
+ Hits        17555    17586      +31     
- Misses       2739     2798      +59     
- Partials      643      646       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant