Skip to content

feat(ir): add TrackedParam struct and SinkVar fields (PR-02)#606

Merged
shivasurya merged 1 commit intomainfrom
shiva/querytype-go-ir-types-sinkvar
Mar 14, 2026
Merged

feat(ir): add TrackedParam struct and SinkVar fields (PR-02)#606
shivasurya merged 1 commit intomainfrom
shiva/querytype-go-ir-types-sinkvar

Conversation

@shivasurya
Copy link
Owner

Summary

  • Add TrackedParam struct to ir_types.go with Index *int, Name string, Return bool fields
  • Add TrackedParams []TrackedParam to both CallMatcherIR and TypeConstrainedCallIR
  • Add SinkParamIndex/SinkParamName to DataflowDetection for reporting which parameter was tainted
  • Add SinkVar to TaintDetection populated from usedVar in FindTaintFlows() — records which variable at the sink carries taint
  • Add TrackedParams to CallSiteMatch for carrying tracking info through the executor pipeline
  • Structural changes only — no filtering logic (that's PR-03)

Test plan

  • gradle buildGo passes
  • gradle testGo passes (zero regressions)
  • gradle lintGo passes (0 issues)
  • gradle lintPython passes
  • No behavior changes — purely additive struct fields with omitempty

🤖 Generated with Claude Code

@shivasurya shivasurya added enhancement New feature or request go Pull requests that update go code labels Mar 14, 2026
@shivasurya shivasurya self-assigned this Mar 14, 2026
@safedep
Copy link

safedep bot commented Mar 14, 2026

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.84%. Comparing base (5254dda) to head (9298363).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files         155      155           
  Lines       20936    20937    +1     
=======================================
+ Hits        17554    17555    +1     
  Misses       2739     2739           
  Partials      643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner Author

shivasurya commented Mar 14, 2026

Copy link
Owner Author

shivasurya commented Mar 14, 2026

Merge activity

  • Mar 14, 3:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 14, 3:18 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 14, 3:19 AM UTC: @shivasurya merged this pull request with Graphite.

@shivasurya shivasurya changed the base branch from shiva/querytype-parameter-targeting to graphite-base/606 March 14, 2026 03:17
@shivasurya shivasurya changed the base branch from graphite-base/606 to main March 14, 2026 03:17
…ields

Adds TrackedParam to CallMatcherIR and TypeConstrainedCallIR for
parameter-level taint sensitivity. Adds SinkParamIndex/SinkParamName
to DataflowDetection. Adds SinkVar to TaintDetection populated from
usedVar in FindTaintFlows(). Adds TrackedParams to CallSiteMatch.
Structural changes only — no filtering logic.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@shivasurya shivasurya force-pushed the shiva/querytype-go-ir-types-sinkvar branch from 2e43d4a to 9298363 Compare March 14, 2026 03:18
@github-actions
Copy link

Code Pathfinder Security Scan

Pass Critical High Medium Low Info

No security issues detected.

Metric Value
Files Scanned 3
Rules 38

Powered by Code Pathfinder

@shivasurya shivasurya merged commit ec41e05 into main Mar 14, 2026
5 checks passed
@shivasurya shivasurya deleted the shiva/querytype-go-ir-types-sinkvar branch March 14, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant