Conversation
make d11 compatable
There was a problem hiding this comment.
Pull request overview
Prepares custom ACCESS Drupal modules for Drupal 11 by broadening declared core compatibility and removing use of deprecated Twig rendering helpers in ticketing webform handlers.
Changes:
- Update multiple module
.info.ymlfiles to include Drupal^11incore_version_requirement. - Replace
twig_render_template()usage with direct Twig service rendering in ticketing email handlers.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/user_profiles/user_profiles.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/ticketing/ticketing.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/ticketing/src/Plugin/WebformHandler/TicketingSendEmailHandler.php | Switches email body rendering from twig_render_template() to Twig service rendering. |
| modules/ticketing/src/Plugin/WebformHandler/RequestOrgsListAddHandler.php | Switches email body rendering from twig_render_template() to Twig service rendering. |
| modules/ticketing/src/Plugin/WebformHandler/AccountSupportHandler.php | Switches email body rendering from twig_render_template() to Twig service rendering. |
| modules/ondemand/ondemand.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/cssn/cssn.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/ccmnet/ccmnet.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_shortcodes/access_shortcodes.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_outages/access_outages.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_news/access_news.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_misc/access_misc.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_match_engagement/access_match_engagement.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_llm/access_llm.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_cilink/access_cilink.info.yml | Adds Drupal 11 compatibility in module metadata. |
| modules/access_affinitygroup/access_affinitygroup.info.yml | Adds Drupal 11 compatibility in module metadata. |
| access.info.yml | Adds Drupal 11 compatibility in the main access module metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| description: "Snippets for small changes or re-usable code" | ||
| type: module | ||
| core_version_requirement: ^9.3 || ^10 | ||
| core_version_requirement: ^9.3 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9.3 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9.3 || ^10 || ^11 for clarity.
| core_version_requirement: ^9.3 || ^10 | ^11 | |
| core_version_requirement: ^9.3 || ^10 || ^11 |
| type: module | ||
| description: Adding in LLM functions. | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
| description: 'CI Link customizations' | ||
| type: module | ||
| core_version_requirement: ^9.3 || ^10 | ||
| core_version_requirement: ^9.3 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9.3 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9.3 || ^10 || ^11 for clarity.
| core_version_requirement: ^9.3 || ^10 | ^11 | |
| core_version_requirement: ^9.3 || ^10 || ^11 |
| description: 'Access' | ||
| type: module | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
| package: Custom | ||
| type: module | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 (and similarly ^10 || ^11) across these .info.yml updates for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
| description: 'Custom functionality for the Match Engagement node type' | ||
| type: module | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
| description: 'Custom functionality for Affinity Groups' | ||
| type: module | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
| package: Custom | ||
| type: module | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 (and similarly ^10 || ^11) across these .info.yml updates for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
| description: 'Custom functionality for OnDemand' | ||
| type: module | ||
| core_version_requirement: ^10 | ||
| core_version_requirement: ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement: ^10 | ^11 uses a different OR operator than several other modules in the repo (||). Consider standardizing on one form (commonly ^10 || ^11) to keep these constraints consistent and easier to scan.
| core_version_requirement: ^10 | ^11 | |
| core_version_requirement: ^10 || ^11 |
| description: 'Custom functionality for ACCESS News' | ||
| type: module | ||
| core_version_requirement: ^9 || ^10 | ||
| core_version_requirement: ^9 || ^10 | ^11 |
There was a problem hiding this comment.
core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.
| core_version_requirement: ^9 || ^10 | ^11 | |
| core_version_requirement: ^9 || ^10 || ^11 |
update image location
## Describe context / purpose for this PR
Drupal 11 prepping
Issue link
https://cyberteamportal.atlassian.net/browse/D8-2356
Any other related PRs?
Link to MultiDev instance
http://md-2356-accessmatch.pantheonsite.io
Checklist for PR author