Skip to content

#2356#1892

Draft
protitude wants to merge 26 commits intomainfrom
md-2356
Draft

#2356#1892
protitude wants to merge 26 commits intomainfrom
md-2356

Conversation

@protitude
Copy link
Copy Markdown
Collaborator

@protitude protitude commented Apr 24, 2026

@protitude protitude requested a review from Copilot April 24, 2026 15:11
@protitude protitude marked this pull request as draft April 24, 2026 15:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is part of the Drupal 11 prep work by removing legacy/unused theme and module code, updating PHP runtime targets to 8.3, and aligning exported configuration/composer dependencies with the updated stack.

Changes:

  • Remove the legacy accesstheme custom theme (templates, assets, build tooling, and optional block config).
  • Remove the unused gdoc_field custom module.
  • Update PHP to 8.3 for Pantheon and DDEV, plus refresh composer and some Views exports.

Reviewed changes

Copilot reviewed 50 out of 70 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
web/themes/custom/accesstheme/templates/views-view--people_with_interest_tags.html.twig Deleted legacy Views template override from removed theme.
web/themes/custom/accesstheme/templates/views-view--people_with_expertise_tags.html.twig Deleted legacy Views template override from removed theme.
web/themes/custom/accesstheme/templates/page.html.twig Deleted legacy page template from removed theme.
web/themes/custom/accesstheme/templates/page-title.html.twig Deleted legacy page title template from removed theme.
web/themes/custom/accesstheme/templates/off-canvas-page-wrapper.html.twig Deleted legacy off-canvas wrapper template from removed theme.
web/themes/custom/accesstheme/templates/menu.html.twig Deleted legacy menu template from removed theme.
web/themes/custom/accesstheme/templates/menu--access-universal-nav-menu.html.twig Deleted legacy menu variant template from removed theme.
web/themes/custom/accesstheme/templates/menu--access-secondary-menu.html.twig Deleted legacy menu variant template from removed theme.
web/themes/custom/accesstheme/templates/menu--access-additional-universal-menu.html.twig Deleted legacy menu variant template from removed theme.
web/themes/custom/accesstheme/templates/match_engagement/views-view-unformatted--match_engagement_view.html.twig Deleted legacy match engagement Views row template from removed theme.
web/themes/custom/accesstheme/templates/match_engagement/views-view--match_engagement_view.html.twig Deleted legacy match engagement Views wrapper template from removed theme.
web/themes/custom/accesstheme/templates/field.html.twig Deleted legacy field template override from removed theme.
web/themes/custom/accesstheme/templates/block--menu--access-universal-nav-menu.html.twig Deleted legacy block/menu macro template from removed theme.
web/themes/custom/accesstheme/templates/affinity_group/node--recommended-cider.html.twig Deleted legacy node template override from removed theme.
web/themes/custom/accesstheme/templates/affinity_group/node--access-active-resources-from-cid--affinity-group.html.twig Deleted legacy node template override from removed theme.
web/themes/custom/accesstheme/templates/affinity_group/field--node--field-coordinator--affinity-group.html.twig Deleted legacy field template override from removed theme.
web/themes/custom/accesstheme/scss/style.scss Deleted theme SCSS entrypoint as part of theme removal.
web/themes/custom/accesstheme/scss/_variables_drupal.scss Deleted Drupal variables overrides as part of theme removal.
web/themes/custom/accesstheme/scss/_variables_bootstrap.scss Deleted Bootstrap variable overrides as part of theme removal.
web/themes/custom/accesstheme/screenshot.png Removed theme screenshot asset.
web/themes/custom/accesstheme/package.json Removed theme frontend build/package manifest.
web/themes/custom/accesstheme/logo.svg Removed theme logo asset.
web/themes/custom/accesstheme/js/accesstheme.js Removed theme JS behaviors.
web/themes/custom/accesstheme/images/user-picture.svg Removed theme placeholder image.
web/themes/custom/accesstheme/favicon.ico Removed theme favicon asset.
web/themes/custom/accesstheme/css/style-50.css.map Removed built CSS sourcemap artifact from removed theme.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_universal_nav_menu.disabled Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_page_title.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_messages.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_local_tasks.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_local_actions.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_help.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_footer.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_content.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_branding.yml Removed theme optional block placement config.
web/themes/custom/accesstheme/config/optional/block.block.accesstheme_additional_menu.disabled Removed theme optional block placement config (disabled).
web/themes/custom/accesstheme/assets/support-title.gif Removed theme asset.
web/themes/custom/accesstheme/assets/SL-medium.png Removed theme asset.
web/themes/custom/accesstheme/assets/SL-medium-advanced.png Removed theme asset.
web/themes/custom/accesstheme/assets/SL-beginner.png Removed theme asset.
web/themes/custom/accesstheme/assets/SL-beginner-medium.png Removed theme asset.
web/themes/custom/accesstheme/assets/SL-all.png Removed theme asset.
web/themes/custom/accesstheme/assets/SL-advanced.png Removed theme asset.
web/themes/custom/accesstheme/assets/NSF_4-Color_bitmap_Logo_350x350.png Removed theme asset.
web/themes/custom/accesstheme/assets/NSF_4-Color_bitmap_Logo.png Removed theme asset.
web/themes/custom/accesstheme/assets/ACCS050322_ACCESS_Brand_Tagline-RGB.png Removed theme asset.
web/themes/custom/accesstheme/assets/ACCS050322_ACCESS_Brand_Support-RGB.png Removed theme asset.
web/themes/custom/accesstheme/accesstheme.theme Removed theme PHP hooks file.
web/themes/custom/accesstheme/accesstheme.libraries.yml Removed theme libraries definition.
web/themes/custom/accesstheme/accesstheme.info.yml Removed theme info definition.
web/themes/custom/accesstheme/accesstheme.breakpoints.yml Removed theme breakpoints definition.
web/themes/custom/accesstheme/README.md Removed theme README/build notes.
web/sites/default/config/default/views.view.user_admin_people.yml Adjusted exported Views config (VBO options + pager heading level placement).
web/sites/default/config/default/views.view.cc_applications.yml Adjusted exported Views config (VBO option placement).
web/sites/default/config/default/core.extension.yml Updated enabled modules list (removed action and layout_builder_expose_all_field_blocks).
web/modules/gdoc_field/templates/gdoc-field.html.twig Removed unused gdoc field formatter template.
web/modules/gdoc_field/src/Plugin/Field/FieldFormatter/GdocFieldFormatter.php Removed unused field formatter implementation.
web/modules/gdoc_field/gdoc_field.module Removed unused module hooks/theme suggestions.
web/modules/gdoc_field/gdoc_field.libraries.yml Removed unused library definition.
web/modules/gdoc_field/gdoc_field.info.yml Removed unused module info file.
web/modules/gdoc_field/css/gdoc_field.css Removed unused module CSS.
web/modules/gdoc_field/README.txt Removed unused module documentation.
web/modules/gdoc_field/LICENSE.txt Removed unused module license file.
pantheon.yml Bumped Pantheon PHP runtime to 8.3.
composer.lock Updated locked dependencies (removals + amp/access branch update).
composer.json Removed some dependencies (e.g., drupal/bootstrap5, drupal/nodeaccess, forks) and updated amp/access constraint.
.ddev/config.yaml Bumped local PHP version to 8.3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread composer.json
Comment thread composer.json
Update drupal req
Update drupal req
Base automatically changed from md-dev to main April 26, 2026 04:30
@a-pasquale
Copy link
Copy Markdown
Contributor

  1. Typo in image path — broken icon for "Advanced" skill level (high confidence, easy fix)

In web/sites/default/config/default/views.view.resources.yml, the image path for SL-advanced.png was updated to /themes/custom/asp-theme/assets/SL-advanced.png, while every other skill-level image in the same template was correctly updated to /themes/contrib/asp-theme/assets/.... Since necyberteam/asp-theme is type drupal-theme, it installs to web/themes/contrib/asp-theme. The Advanced icon will 404 in production. Single-character fix: custom → contrib.

  1. action module disabled while VBO views still depend on it (high confidence, likely breaks)

web/sites/default/config/default/core.extension.yml removes action: 0, but the Views Bulk Operations configuration in views.view.cc_applications.yml and views.view.user_admin_people.yml still references action_id plugins campuschampions_approve_cc_decline, campuschampions_password_reset_action, user_block_user_action, etc.) that are registered through the action subsystem. Additionally, actions_permissions: 0 and ~150 system.action.* config files remain in config/default. In D10, actions_permissions declares a hard dependency on action. In D11, the action module's responsibilities moved into system — the removal might be intentional D11 prep, but the ecosystem actions_permissions, system.action.* configs, VBO action_ids) hasn't been migrated to match. Either the action module needs to stay enabled, or the dependent configs need to be cleaned up in this PR.

  1. layout_builder_expose_all_field_blocks removed without explanation (medium confidence)

core.extension.yml removes layout_builder_expose_all_field_blocks: 0. This module was explicitly added in PR #1335 zs part of the D10.4 upgrade work. If any Layout Builder pages were configured to use field blocks exposed by this module, those layouts will silently lose those blocks. Worth confirming no Layout Builder pages depend on it, or documenting why it's no longer needed for D11.

  1. webform.webform.rt_ticketing_system.yml still references the deleted accesstheme (high confidence, Copilot flagged, unaddressed)

This file is NOT in the PR's changed files, but web/sites/default/config/default/webform.webform.rt_ticketing_system.yml:151 contains page_theme_name: accesstheme. With the theme directory deleted, the webform will fail to resolve its page theme. Copilot flagged this on 2026-04-24; the PR hasn't been updated to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants