Skip to content

access: d8-2356 #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
protitude wants to merge 2 commits into
base: 3.0.x
Choose a base branch
from
Open

access: d8-2356 #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea508a
access: d8-2356
protitude Apr 23, 2026
6f3a775
affinitygroup: d8-2356
protitude Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion access.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Access
description: 'Access'
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access:access_llm
2 changes: 1 addition & 1 deletion modules/access_affinitygroup/access_affinitygroup.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Access Affinity Group
description: 'Custom functionality for Affinity Groups'
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
Expand Down
2 changes: 1 addition & 1 deletion modules/access_affinitygroup/src/Plugin/EmailWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ private function ccNewsCommonHTML($newsBody, $topExtra) {
$fbIcon = $this->imageUrl('circleIconFacebook.png');
$bsIcon = $this->imageUrl('circleIconBluesky.png');
$ytIcon = $this->imageUrl('circleIconYoutube.png');
$nsfLogo = ACCESS_SUPPORT_URL . '/themes/custom/accesstheme/assets/NSF_4-Color_bitmap_Logo_350x350.png';
$nsfLogo = ACCESS_SUPPORT_URL . '/themes/contrib/asp-theme/assets/NSF_4-Color_bitmap_Logo_350x350.png';

$emailText = <<<EMAILTEXT1
<html lang="en-US">
Expand Down
2 changes: 1 addition & 1 deletion modules/access_cilink/access_cilink.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Access CI Link
description: 'CI Link customizations'
type: module
core_version_requirement: ^9.3 || ^10
core_version_requirement: ^9.3 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9.3 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9.3 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9.3 || ^10 | ^11
core_version_requirement: ^9.3 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
2 changes: 1 addition & 1 deletion modules/access_llm/access_llm.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Access LLM
type: module
description: Adding in LLM functions.
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion modules/access_match_engagement/access_match_engagement.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Access Match Engagement
description: 'Custom functionality for the Match Engagement node type'
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
2 changes: 1 addition & 1 deletion modules/access_misc/access_misc.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Access Misc
description: "Snippets for small changes or re-usable code"
type: module
core_version_requirement: ^9.3 || ^10
core_version_requirement: ^9.3 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9.3 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9.3 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9.3 || ^10 | ^11
core_version_requirement: ^9.3 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
Expand Down
2 changes: 1 addition & 1 deletion modules/access_news/access_news.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Access News
description: 'Custom functionality for ACCESS News'
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
2 changes: 1 addition & 1 deletion modules/access_outages/access_outages.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: ACCESS Outages
description: ACCESS Outages module
package: Custom
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
version: 1.0
dependencies:
- access
Expand Down
2 changes: 1 addition & 1 deletion modules/access_shortcodes/access_shortcodes.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: ACCESS Shortcodes
description: 'Shortcodes for the ACCESS theme'
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
2 changes: 1 addition & 1 deletion modules/ccmnet/ccmnet.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: ccmnet
description: 'Custom functionality for the ccmnet'
type: module
core_version_requirement: ^10
core_version_requirement: ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement: ^10 | ^11 uses a different OR operator than several other modules in the repo (||). Consider standardizing on one form (commonly ^10 || ^11) to keep these constraints consistent and easier to scan.

Suggested change
core_version_requirement: ^10 | ^11
core_version_requirement: ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
2 changes: 1 addition & 1 deletion modules/cssn/cssn.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: CSSN
description: 'Computational Science and Support Network'
type: module
core_version_requirement: ^9.4 || ^10
core_version_requirement: ^9.4 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9.4 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9.4 || ^10 || ^11 for clarity.

Suggested change
core_version_requirement: ^9.4 || ^10 | ^11
core_version_requirement: ^9.4 || ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
Expand Down
2 changes: 1 addition & 1 deletion modules/ondemand/ondemand.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: ondemand
description: 'Custom functionality for OnDemand'
type: module
core_version_requirement: ^10
core_version_requirement: ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement: ^10 | ^11 uses a different OR operator than several other modules in the repo (||). Consider standardizing on one form (commonly ^10 || ^11) to keep these constraints consistent and easier to scan.

Suggested change
core_version_requirement: ^10 | ^11
core_version_requirement: ^10 || ^11

Copilot uses AI. Check for mistakes.
package: Custom
dependencies:
- access
18 changes: 8 additions & 10 deletions modules/ticketing/src/Plugin/WebformHandler/AccountSupportHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,14 @@ public function postSave(WebformSubmissionInterface $webformSubmission, $update

public function getXMailMessageBody($data) {
$ticketing_module_path = \Drupal::service('extension.list.module')->getPath('ticketing');
return twig_render_template(
$ticketing_module_path . '/templates/account-support-mail.html.twig',
[
'theme_hook_original' => 'not-applicable',
'name' => $data['your_name'],
'email' => $data['email'],
'access_id' => $data['access_id'],
'comment' => $data['comment'],
]
);
/** @var \Twig\Environment $twig */
$twig = \Drupal::service('twig');
return (string) $twig->load($ticketing_module_path . '/templates/account-support-mail.html.twig')->render([
'name' => $data['your_name'],
'email' => $data['email'],
'access_id' => $data['access_id'],
'comment' => $data['comment'],
]);
}

}
30 changes: 14 additions & 16 deletions modules/ticketing/src/Plugin/WebformHandler/RequestOrgsListAddHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,20 @@ public function postSave(WebformSubmissionInterface $webformSubmission, $update
*/
public function getMailMessageBody($data) {
$ticketing_module_path = \Drupal::service('extension.list.module')->getPath('ticketing');
return twig_render_template(
$ticketing_module_path . '/templates/request-orgs-list-add-mail.html.twig',
[
'theme_hook_original' => 'not-applicable',
'name' => $data['your_name'],
'email' => $data['your_email'],
'organization' => $data['your_organization'],
'address_line_1' => $data['address_line_1'] ?? '',
'address_line_2' => $data['address_line_2'] ?? '',
'city' => $data['city'] ?? '',
'state_province_region' => $data['state_province_region'] ?? '',
'zip_postal_code' => $data['zip_postal_code'] ?? '',
'country' => $data['country'] ?? '',
'organization_webpage' => $data['organization_webpage'] ?? '',
]
);
/** @var \Twig\Environment $twig */
$twig = \Drupal::service('twig');
return (string) $twig->load($ticketing_module_path . '/templates/request-orgs-list-add-mail.html.twig')->render([
'name' => $data['your_name'],
'email' => $data['your_email'],
'organization' => $data['your_organization'],
'address_line_1' => $data['address_line_1'] ?? '',
'address_line_2' => $data['address_line_2'] ?? '',
'city' => $data['city'] ?? '',
'state_province_region' => $data['state_province_region'] ?? '',
'zip_postal_code' => $data['zip_postal_code'] ?? '',
'country' => $data['country'] ?? '',
'organization_webpage' => $data['organization_webpage'] ?? '',
]);
}

}
18 changes: 8 additions & 10 deletions modules/ticketing/src/Plugin/WebformHandler/TicketingSendEmailHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,14 @@ public function postSave(WebformSubmissionInterface $webformSubmission, $update

public function getXMailMessageBody($description, $tags, $suggested_tag, $from_email) {
$ticketing_module_path = \Drupal::service('extension.list.module')->getPath('ticketing');
return twig_render_template(
$ticketing_module_path . '/templates/ticketing-mail.html.twig',
[
'theme_hook_original' => 'not-applicable',
'problem_description' => $description,
'tags' => $tags,
'suggested_tag' => $suggested_tag,
'email' => $from_email,
]
);
/** @var \Twig\Environment $twig */
$twig = \Drupal::service('twig');
return (string) $twig->load($ticketing_module_path . '/templates/ticketing-mail.html.twig')->render([
'problem_description' => $description,
'tags' => $tags,
'suggested_tag' => $suggested_tag,
'email' => $from_email,
]);
}

}
2 changes: 1 addition & 1 deletion modules/ticketing/ticketing.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Ticketing
description: Ticketing Module
package: Custom
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 (and similarly ^10 || ^11) across these .info.yml updates for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
version: 1.0
dependencies:
- access
2 changes: 1 addition & 1 deletion modules/user_profiles/user_profiles.info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: User Profiles
description: User Profiles Module
package: Custom
type: module
core_version_requirement: ^9 || ^10
core_version_requirement: ^9 || ^10 | ^11
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core_version_requirement mixes || and | OR operators in the same constraint (e.g. ^9 || ^10 | ^11). Even if Composer can parse this, it’s harder to read and inconsistent with other module info files that use ||. Consider standardizing to ^9 || ^10 || ^11 (and similarly ^10 || ^11) across these .info.yml updates for clarity.

Suggested change
core_version_requirement: ^9 || ^10 | ^11
core_version_requirement: ^9 || ^10 || ^11

Copilot uses AI. Check for mistakes.
version: 1.0
dependencies:
- access