chore(CI): add goimports to linter

[Elbehery]

fixes #992

cc @ahrtr @ivanvc @fuweid

[Elbehery]

@ahrtr there is also another formatting tool (i.e. gci) which offers more options, but for our purpose goimports should be fine

Please let me know if you want to add gci as well

Also I have added a step to all workflows to run golangci-lint explicitly.

As it is defined in the reusable workflow, i expected it to be running by default, but looks like it was not the case

[Elbehery]

Now I have to use gci, because goimports can not run as a rule within the linter 🤔

[ahrtr]

LGTM & thx

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, Elbehery, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

I think it would be cleaner if rather than running the linter in every workflow, we ran it along with #986. That way, we can lint all the platform-specific files.

[Elbehery]

I think it would be cleaner if rather than running the linter in every workflow, we ran it along with #986. That way, we can lint all the platform-specific files.

+1, I have initially had it running, but yesterday @ahrtr suggested to remove it

[ahrtr]

I think it would be cleaner if rather than running the linter in every workflow, we ran it along with #986. That way, we can lint all the platform-specific files.

Agreed, please feel free to enhance it in followup PR, thx