Skip to content

[release-1.3] chore(CI): add golangci linter rules#1072

Closed
Elbehery wants to merge 1 commit intoetcd-io:release-1.3from
Elbehery:20250821_backport_linter_1.3
Closed

[release-1.3] chore(CI): add golangci linter rules#1072
Elbehery wants to merge 1 commit intoetcd-io:release-1.3from
Elbehery:20250821_backport_linter_1.3

Conversation

@Elbehery
Copy link
Copy Markdown
Member

@Elbehery Elbehery commented Aug 21, 2025 •
edited
Loading

backport of #993

cc @ahrtr @ivanvc

repalces #995

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Copy Markdown
Member

ivanvc commented Aug 21, 2025

@Elbehery, can you update golangci-lint to use version v2.4.0? And let's see if the Windows error persists.

@Elbehery
[release-1.3] chore(CI): add golangci linter rules
d6a782f 
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
@Elbehery Elbehery force-pushed the 20250821_backport_linter_1.3 branch from c2c7216 to d6a782f Compare August 21, 2025 22:42
@Elbehery
Copy link
Copy Markdown
Member Author

Elbehery commented Aug 21, 2025

@Elbehery, can you update golangci-lint to use version v2.4.0? And let's see if the Windows error persists.

i think we need to install v2.4.0 in a step before using it

lets see

@Elbehery
Copy link
Copy Markdown
Member Author

Elbehery commented Aug 22, 2025 

 golangci-lint run ./...
0 issues.

@Elbehery
Copy link
Copy Markdown
Member Author

Elbehery commented Aug 22, 2025 

 golangci-lint run ./...
0 issues.

golangci-lint version                                                        
golangci-lint has version 2.4.0 built with go1.25.0 from 43d03392 on 2025-08-13T23:36:29Z

@Elbehery
Copy link
Copy Markdown
Member Author

Elbehery commented Aug 22, 2025

@ivanvc gh does not use v2.4.0 yet :/

@ivanvc
Copy link
Copy Markdown
Member

ivanvc commented Aug 22, 2025

Ah, 2.4.0 uses Go 1.25. We need a previous version (2.3.1). But Windows is still failing. I'll try to set up a Windows machine to replicate this locally.

@github-actions github-actions Bot added the stale label Dec 9, 2025
@github-actions github-actions Bot closed this Dec 30, 2025
@Elbehery Elbehery deleted the 20250821_backport_linter_1.3 branch March 25, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/M stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Elbehery @k8s-ci-robot @ivanvc