[release-1.3] chore(CI): add golangci linter rules#995
[release-1.3] chore(CI): add golangci linter rules#995Elbehery wants to merge 1 commit intoetcd-io:release-1.3from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Elbehery The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Elbehery
force-pushed
the
20250615_backport_linter_1.3
branch
3 times, most recently
from
04815a4 to
eb7be2f
Compare
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
20250615_backport_linter_1.3
branch
from
eb7be2f to
013236f
Compare
|
/retest |
|
/retest |
I don't think we want to merge a pull request if it will break the CI. Would it be possible to use golangci-lint v1, with the rules you enabled, rather than bumping the version to 2? |
unfortunately no, these rules require but if we were to maintain the same linting across release branches, how would we proceed ? cc @ahrtr |
|
We don't see any issue on main branch. Probably it's due to different golang version? Eventually we will bump to v2, but for now let's do not get stuck here (I don't mind closing this PR for now), we should always keep the workflow green. |
|
lgtm 👍🏽 |
|
alright, let me reopen, delete the branch . hold on 👍🏽 |
4 participants
backport of #993
cc @ahrtr @ivanvc