[release-1.3] Bump golangcilint to v2#1177
Merged
ahrtr merged 2 commits intoetcd-io:release-1.3from Apr 16, 2026
Merged
Conversation
Manual backport of etcd-io#954 / 675a3be. Silence linters that fail with the current state of the code, as we don't want to change the stable release code. Signed-off-by: Ivan Valdes <ivan@vald.es>
Member
|
/ok-to-test |
This has been a dead end for several attempts. Golangci-lint fails for every file for Windows. The easier approach, given this is a stable rlease branch is to disable linting in Windows. Signed-off-by: Ivan Valdes <ivan@vald.es>
Member
Author
ahrtr
approved these changes
Apr 15, 2026
Elbehery
approved these changes
Apr 15, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, Elbehery, ivanvc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #954 / 675a3be.
Silence linters that fail with the current state of the code, as we don't want to change the stable release code.
Trying to unblock #1158 / The Go version bump (etcd-io/etcd#21458).