[release-1.3] Bump go to 1.25.8

[shuan1026]

Ref: etcd-io/etcd#21364
Ref: etcd-io/etcd#21458

From https://go.dev/doc/devel/release#go1.25.0

go1.25.7 (released 2026-02-04) includes security fixes to the go command and the crypto/tls package, as well as bug fixes to the compiler and the crypto/x509 package.
go1.25.8 (released 2026-03-05) includes security fixes to the html/template, net/url, and os packages, as well as bug fixes to the go command, the compiler, and the os package. See the Go 1.25.8 milestone on our issue tracker for details.

[ahrtr]

/ok-to-test

[ivanvc]

Same for this one, it needs a #954 backport. That's what is making the workflows fail.

[ahrtr]

pls refer to https://github.com/etcd-io/etcd/blob/0f5cee16488816ad9e9ecb7cbdfd2aa74b163aeb/scripts/test_lib.sh#L515-L532

[fuweid]

@shuan1026 are you still working on this? 1.25.9 is out. if you don't have time, please let us know. thanks

[shuan1026]

@shuan1026 are you still working on this? 1.25.9 is out. if you don't have time, please let us know. thanks

Hi @fuweid, yes I'm still working on this, thanks for the heads-up

Here's a summary of what's been happening:

The original PRs #1157 (release-1.4) and #1158 (release-1.3) ran into a test-windows CI failure.

Two related PRs #1178 (release-1.4) and #1177 (release-1.3) were opened to bump golangci-lint to v2, which was trying to unblock the CI. The discussion in #1178 then led to #1181 on main, which introduced a dedicated lint CI job.

I've now backported the approach from #1181 into this PR (#1157) to fix the Windows CI issue — moving lint into a dedicated job with shell: bash and go-version-file to ensure the correct Go version is used on Windows runners. Also removed the gci formatter from .golangci.yaml as it was incorrectly flagging all files on Windows due to CRLF line endings.

I'll also update #1158 accordingly for release-1.3. And I can update both PRs to target Go 1.25.9 if that's preferred

I'm fairly new to contributing here, if there's anything I should do differently or if you have any suggestions, please don't hesitate to let me know. Thanks again for your help

[shuan1026]

Hi @fuweid

After #1177 is merged into release-1.3, this PR only needs a rebase to pass CI.

• [release-1.3] Bump golangcilint to v2 #1177 upgrades golangci-lint to v2, adds .golangci.yaml with appropriate suppressions (avoiding any changes to stable code), and disables linting on Windows to avoid the gofmt CRLF issue.
• This PR adds the Go 1.25.8 bump and pins actions/checkout / actions/setup-go to full commit SHAs across tests.yaml, failpoint_test.yaml, and robustness_test.yaml (required by the etcd-io/bbolt action policy).

Thanks!

[fuweid]

could you please update this to v1.25 as well?

[ivanvc]

However, we need to address this.

[fuweid]

@ahrtr do you mind review and merge this? I can handle the followup .

[fuweid]

Or I can carry on this one 😅

[ivanvc]

That's why I suggested maybe with the previous work to make it work (golangci-lint backport), doing this PR from scratch, pointing to 1.25.9 shouldn't be hard.

I suggest not merging in the current state, as this line should point to 1.25, not 1.24.

[ahrtr]

@ahrtr do you mind review and merge this? I can handle the followup .

done.

[fuweid]

If you don't mind, we can update this to go1.25.9 as well.

[ivanvc]

I wouldn't mind doing this in a follow-up PR to expedite this merge (it's been open for a long time).

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, Elbehery, shuan1026

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment