Skip to content

[release-1.3] Bump golangcilint to v2 #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahrtr merged 2 commits into from
Apr 16, 2026
+37 −7
Merged

[release-1.3] Bump golangcilint to v2 #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06452b6
Bump golangcilint to v2
ivanvc Apr 1, 2026
5276da2
Remove linting from Windows
ivanvc Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ jobs:
exit 1
;;
esac
- name: golangci-lint
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
- name: Run golangci-lint
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
with:
version: v1.64.8
version: v2.10.1

test-windows:
strategy:
Expand Down Expand Up @@ -87,10 +87,6 @@ jobs:
;;
esac
shell: bash
- name: golangci-lint
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
with:
version: v1.64.8

coverage:
needs: ["test-linux", "test-windows"]
Expand Down
34 changes: 34 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
formatters:
enable:
- gofmt
issues:
max-same-issues: 0
linters:
default: none
enable: # please keep this alphabetized
- errcheck
- govet
- ineffassign
- staticcheck
- unused
exclusions:
presets:
- comments
- common-false-positives
- legacy
- std-error-handling
settings: # please keep this alphabetized
staticcheck:
checks:
- all
- -QF1003 # Convert if/else-if chain to tagged switch
- -QF1004 # Use strings.ReplaceAll instead of strings.Replace with n == -1
- -QF1008 # Omit embedded fields from selector expression
- -QF1010 # Convert slice of bytes to string when printing it
- -QF1011 # Omit redundant type from variable declaration
- -ST1003 # Poorly chosen identifier
- -ST1005 # Incorrectly formatted error string
- -ST1006 # Poorly chosen receiver name
- -ST1012 # Poorly chosen name for error variable
- -ST1016 # Use consistent method receiver names
version: "2"
Loading