Skip to content

stats: add tag utility test. the tag joiner was previously covered by other tests, but lacked its own unit test #44074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbpcode merged 3 commits into from
Mar 25, 2026
+51 −0
Merged

stats: add tag utility test. the tag joiner was previously covered by other tests, but lacked its own unit test #44074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e93da06
add tag utility test. the tag joiner was previously covered by other …
jmarantz Mar 22, 2026
7085105
use dynamic pool.
jmarantz Mar 22, 2026
9bcd7d2
remove extra semi-colon.
jmarantz Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/common/stats/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,17 @@ envoy_benchmark_test(
benchmark_binary = "tag_extractor_impl_benchmark",
)

envoy_cc_test(
name = "tag_utility_test",
srcs = ["tag_utility_test.cc"],
rbe_pool = "6gig",
deps = [
":stat_test_utility_lib",
"//source/common/stats:symbol_table_lib",
"//source/common/stats:tag_utility_lib",
],
)

envoy_cc_test(
name = "thread_local_store_test",
srcs = ["thread_local_store_test.cc"],
Expand Down
43 changes: 43 additions & 0 deletions test/common/stats/tag_utility_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
#include "source/common/stats/tag_utility.h"

#include "source/common/stats/symbol_table.h"

#include "gtest/gtest.h"

namespace Envoy {
namespace Stats {
namespace TagUtility {

namespace {

class TagUtilityTest : public ::testing::Test {
protected:
SymbolTable symbol_table_;
StatNamePool symbolic_pool_{symbol_table_};
StatNamePool dynamic_pool_{symbol_table_};;
};

TEST_F(TagUtilityTest, Symbolic) {
StatNameTagVector tags;
tags.push_back(StatNameTag(symbolic_pool_.add("tag_name"), symbolic_pool_.add("tag_value")));
TagStatNameJoiner joiner(symbolic_pool_.add("prefix"),
symbolic_pool_.add("name"),
tags, symbol_table_);
EXPECT_EQ("prefix.name.tag_name.tag_value", symbol_table_.toString(joiner.nameWithTags()));
EXPECT_EQ("prefix.name", symbol_table_.toString(joiner.tagExtractedName()));
}

TEST_F(TagUtilityTest, Dynamic) {
StatNameTagVector tags;
tags.push_back(StatNameTag(dynamic_pool_.add("tag_name"), dynamic_pool_.add("tag_value")));
TagStatNameJoiner joiner(dynamic_pool_.add("prefix"),
dynamic_pool_.add("name"),
tags, symbol_table_);
EXPECT_EQ("prefix.name.tag_name.tag_value", symbol_table_.toString(joiner.nameWithTags()));
EXPECT_EQ("prefix.name", symbol_table_.toString(joiner.tagExtractedName()));
}

} // namespace
} // namespace TagUtility
} // namespace Stats
} // namespace Envoy
Loading