stats: add tag utility test. the tag joiner was previously covered by other tests, but lacked its own unit test#44074
Merged
wbpcode merged 3 commits intoenvoyproxy:mainfrom Mar 25, 2026
Conversation
…tests, but lacked its own unit test Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
@TAOXUY fyi |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a focused unit test for Envoy::Stats::TagUtility::TagStatNameJoiner, documenting the expected string output for a stat name with appended tag name/value pairs.
Changes:
- Introduces
tag_utility_test.ccwith basic joiner expectations for “symbolic” and “dynamic” cases. - Registers the new unit test target in
test/common/stats/BUILD.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/common/stats/tag_utility_test.cc |
Adds new unit tests that assert TagStatNameJoiner output for names with tag suffixes. |
test/common/stats/BUILD |
Adds a new envoy_cc_test target to build/run the new unit test. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: adds a targeted unit tests, serving as documentation for how the stats tag name joiner works.
Additional Description:
Risk Level: very low; just adds a unit test.
Testing:
Docs Changes:
Release Notes:
Platform Specific Features: