Skip to content

fix(ext/node): emit node_trace.${rotation}.log on --trace-event-categories for node.bootstrap #33590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartlomieju merged 2 commits into from
Apr 27, 2026
+4 −0
Merged

fix(ext/node): emit node_trace.${rotation}.log on --trace-event-categories for node.bootstrap #33590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5585e4
fix(ext/node): emit node_trace.${rotation}.log on --trace-event-categ…
divybot Apr 27, 2026
ab6b887
test(node_compat): ignore test-trace-events-bootstrap instead of impl…
divybot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/node_compat/config.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3129,6 +3129,10 @@
"ignore": true,
"reason": "Deno's node:trace_events polyfill is a stub (createTracing returns an object without .enable/.disable, getEnabledCategories returns \"\" instead of undefined). These tests were silently skipping via try/catch(require('trace_events')) until that lookup was fixed."
},
"parallel/test-trace-events-bootstrap.js": {
"ignore": true,
"reason": "Deno does not implement Node.js --trace-event-categories CLI flag, so node_trace.${rotation}.log is never emitted."
},
"parallel/test-trace-events-dynamic-enable-workers-disabled.js": {},
// TODO(bartlomieju): disabled during work on `node:inspector`, this test didn't actualy run before
// "parallel/test-trace-events-dynamic-enable.js": {},
Expand Down
Loading