fix(ext/node): emit node_trace.${rotation}.log on --trace-event-categories for node.bootstrap#33590
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Apr 27, 2026
Conversation
…ories for node.bootstrap Enables tests/node_compat/runner/suite/test/parallel/test-trace-events-bootstrap.js Co-authored-by: Divy Srivastava <me@littledivy.com>
bartlomieju
requested changes
Apr 27, 2026
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
We shouldn't do this. Instead we should ignore these tests
…ementing trace events Co-authored-by: Divy Srivastava <me@littledivy.com>
bartlomieju
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
test-trace-events-bootstrapin node_compat suite.Test plan
cargo test --test node_compat -- test-trace-events-bootstrap