Skip to content

consensus/bor, internal/cli: full grpc implementation #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcello33 wants to merge 8 commits into
base: develop
Choose a base branch
from

address comments

5d681d7
Select commit
Loading
Failed to load commit list.
Open

consensus/bor, internal/cli: full grpc implementation #2194

address comments
5d681d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 23, 2026 in 1s

52.01% (+0.01%) compared to 7cd4e72

View this Pull Request on Codecov

52.01% (+0.01%) compared to 7cd4e72

Details

Codecov Report

❌ Patch coverage is 50.19011% with 131 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.01%. Comparing base (7cd4e72) to head (5d681d7).

Files with missing lines Patch % Lines
internal/cli/server/api_service.go 40.22% 103 Missing and 4 partials ⚠️
internal/cli/server/utils.go 0.00% 10 Missing ⚠️
internal/cli/server/command.go 30.00% 6 Missing and 1 partial ⚠️
consensus/bor/bor.go 44.44% 4 Missing and 1 partial ⚠️
internal/cli/server/server.go 95.91% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2194      +/-   ##
===========================================
+ Coverage    51.99%   52.01%   +0.01%     
===========================================
  Files          884      884              
  Lines       155503   155735     +232     
===========================================
+ Hits         80854    80999     +145     
- Misses       69448    69531      +83     
- Partials      5201     5205       +4
Files with missing lines Coverage Δ
consensus/bor/api.go 86.12% <ø> (ø)
internal/cli/server/config.go 63.84% <ø> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
internal/cli/server/server.go 37.39% <95.91%> (+6.87%) ⬆️
consensus/bor/bor.go 83.35% <44.44%> (-0.29%) ⬇️
internal/cli/server/command.go 37.70% <30.00%> (-0.45%) ⬇️
internal/cli/server/utils.go 0.00% <0.00%> (ø)
internal/cli/server/api_service.go 31.34% <40.22%> (+31.34%) ⬆️

... and 18 files with indirect coverage changes

Files with missing lines Coverage Δ
consensus/bor/api.go 86.12% <ø> (ø)
internal/cli/server/config.go 63.84% <ø> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
internal/cli/server/server.go 37.39% <95.91%> (+6.87%) ⬆️
consensus/bor/bor.go 83.35% <44.44%> (-0.29%) ⬇️
internal/cli/server/command.go 37.70% <30.00%> (-0.45%) ⬇️
internal/cli/server/utils.go 0.00% <0.00%> (ø)
internal/cli/server/api_service.go 31.34% <40.22%> (+31.34%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov