Skip to content

consensus/bor, internal/cli: full grpc implementation #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcello33 wants to merge 8 commits into
base: develop
Choose a base branch
from

address comments

5d681d7
Select commit
Loading
Failed to load commit list.
Open

consensus/bor, internal/cli: full grpc implementation #2194

address comments
5d681d7
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 23, 2026 in 17m 52s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing eth/tracers/data.csv:1-10 data.csv row reordering is pure diff noise from non-deterministic map iteration

Annotations

Check notice on line 10 in eth/tracers/data.csv

See this annotation in the file changed.

@claude claude / Claude Code Review

data.csv row reordering is pure diff noise from non-deterministic map iteration 

This is a pre-existing issue: `eth/tracers/data.csv` is listed in `eth/tracers/.gitignore` yet committed to the repo, and its rows are generated by iterating Go maps (`GetReadMapDump`/`GetWriteMapDump` → `MVReadList`/`MVWriteList` in `core/state/statedb.go`) whose iteration order is non-deterministic — so every regeneration shuffles rows within each TransactionIndex group. The simplest action on this PR is to revert `eth/tracers/data.csv` to its pre-PR contents so the 40-line diff of pure noise
View more details on Claude