Skip to content

address comments

5d681d7
Select commit
Loading
Failed to load commit list.
Open

consensus/bor, internal/cli: full grpc implementation #2194

address comments
5d681d7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 23, 2026 in 58s

Annotations

Check warning on line 206 in internal/cli/server/grpc_auth_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ26q4ImODWJA9QzweUQ&open=AZ26q4ImODWJA9QzweUQ&pullRequest=2194

Check failure on line 209 in internal/cli/server/api_service.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "total difficulty overflows uint64" 3 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ27pXmWIrxNTu1xByrL&open=AZ27pXmWIrxNTu1xByrL&pullRequest=2194

Check failure on line 83 in internal/cli/server/command.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ27x50qUqW5vcyKNE5w&open=AZ27x50qUqW5vcyKNE5w&pullRequest=2194

Check failure on line 108 in internal/cli/server/api_service.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "header not found" 3 times.

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ27pXmWIrxNTu1xByrK&open=AZ27pXmWIrxNTu1xByrK&pullRequest=2194