Strip LTO flags from static Lua module build

[hanxizh9910]

Summary

The daily CI sanitizer jobs with clang are failing during the build step.
When the static Lua module is built with -flto, the .o files contain
LLVM bitcode that gets archived into libvalkeylua.a. The system linker
cannot read this bitcode, causing build failures:

/usr/bin/ld: /home/runner/work/valkey/valkey/src/modules/lua/libvalkeylua.a: member /home/runner/work/valkey/valkey/src/modules/lua/libvalkeylua.a(debug_lua.o) in archive is not an object

The previous fix (#3546) pinned clang to version 17, but this was
insufficient, the issue is not just a version mismatch but that the
system linker fundamentally cannot read LTO bitcode from .a archives.

Example failure: https://github.com/valkey-io/valkey/actions/runs/24865821147/job/72801509768

Fix

Strip LTO flags from OPTIMIZATION in the Lua module Makefile using
override

Tested: https://github.com/hanxizh9910/valkey/actions/runs/24913834442

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.33%. Comparing base (d2db0c2) to head (caf189a).

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #3555      +/-   ##
============================================
- Coverage     76.35%   76.33%   -0.03%     
============================================
  Files           159      159              
  Lines         80054    80054              
============================================
- Hits          61125    61106      -19     
- Misses        18929    18948      +19     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hpatro]

I've reverted #3546 in #3556 independently. I'll let @eifrah-aws review this.

[eifrah-aws]

I would move this logic to the Lua makefile. (modules/lua/Makefile)

This part:

LUA_MODULE_OPTIMIZATION=$(subst -flto,,$(subst -ffat-lto-objects,,$(subst -flto=auto,,$(OPTIMIZATION))))

[roshkhatri]

LGTM, this incorporates @eifrah-aws's suggestion

[sarthakaggarwal97]

@hanxizh9910 can you share the latest test link, the one in the PR description tests the changes done in source makefile.

[hanxizh9910]

@hanxizh9910 can you share the latest test link, the one in the PR description tests the changes done in source makefile.

@sarthakaggarwal97 Hi this is the latest test link: https://github.com/hanxizh9910/valkey/actions/runs/24913834442. I also updated the PR description