Fix some flaky tests using CLIENT REPLY OFF#3452
Merged
enjoy-binbin merged 1 commit intovalkey-io:unstablefrom Apr 8, 2026
Merged
Conversation
Some test cases write thoughsands of commands in a pipeline and afterwards read the replies. This can lead to TCP ACK being dropped and the connection broken. CLIENT REPLY OFF prevents this. "Main db not affected when fail to diskless load" in cluster/diskless-load-swapdb has been observed to be flaky. The others are just defensive but they follow the same pattern. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3452 +/- ##
============================================
- Coverage 76.57% 76.50% -0.08%
============================================
Files 157 157
Lines 79026 79026
============================================
- Hits 60515 60458 -57
- Misses 18511 18568 +57 🚀 New features to boost your workflow:
|
Nikhil-Manglore
approved these changes
Apr 7, 2026
enjoy-binbin
approved these changes
Apr 8, 2026
sarthakaggarwal97
pushed a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
Some test cases write thoughsands of commands in a pipeline and afterwards read the replies. This can lead to TCP ACK being dropped and the connection broken. CLIENT REPLY OFF prevents this. "Main db not affected when fail to diskless load" in cluster/diskless-load-swapdb has been observed to be flaky. The others are just defensive but they follow the same pattern. Similar fixes in the past: valkey-io#3430, valkey-io#2483. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
Cherry-pick of c35dbdf from unstable. Fixes corrupt-dump-fuzzer, rdb COW test, diskless-load-swapdb, and module lazyfree test by using CLIENT REPLY OFF to prevent TCP backpressure. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
Cherry-pick of c35dbdf from unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
Cherry-pick of c35dbdf from unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
Cherry-pick of c35dbdf from unstable. Adapted: valkey_deferring_client -> redis_deferring_client. Note: diskless-load-swapdb.tcl is at tests/cluster/tests/ on 7.2 (moved to tests/unit/cluster/ on later branches). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This was referenced Apr 16, 2026
sarthakaggarwal97
added a commit
to sarthakaggarwal97/valkey
that referenced
this pull request
Apr 16, 2026
Use CLIENT REPLY OFF pattern in the defrag eval scripts test which pipelines 50,000 script loads + 50,000 set commands. Without this, the TCP send buffer fills up causing 'I/O error reading reply'. Same CLIENT REPLY OFF pattern as valkey-io#3430 and valkey-io#3452. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test cases write thoughsands of commands in a pipeline and afterwards read the replies. This can lead to TCP ACK being dropped and the connection broken. CLIENT REPLY OFF prevents this.
"Main db not affected when fail to diskless load" in cluster/diskless-load-swapdb has been observed to be flaky.
The others are just defensive but they follow the same pattern.
Similar fixes in the past: #3430, #2483.