Backport test stability fixes to 8.0#3525
Closed
sarthakaggarwal97 wants to merge 6 commits intovalkey-io:8.0from
Closed
Backport test stability fixes to 8.0#3525sarthakaggarwal97 wants to merge 6 commits intovalkey-io:8.0from
sarthakaggarwal97 wants to merge 6 commits intovalkey-io:8.0from
Conversation
Cherry-pick of f3b6470 from unstable. Skipped dual-channel-replication.tcl (lazyfree test doesn't exist on 8.0). Resolved memefficiency.tcl: kept $rd close after CLIENT REPLY pattern. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Cherry-pick of c35dbdf from unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Partial cherry-pick of c9ce3e0 from unstable. Applied: list.tcl, set.tcl, violations.tcl (reduce test sizes for CI runners). Skipped: daily.yml, test_quicklist.cpp (not applicable to 8.0). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Cast r to uint32_t before left-shifting by 16 to avoid signed integer overflow when r >= 32768. This fixes the UBSan error: 'left shift of 36625 by 16 places cannot be represented in type int' Already fixed on unstable via valkey-io#3241 (GoogleTest migration). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Add explicit flush calls every 100 iterations in pipelining loops to prevent TCP backpressure when sending 50,000+ commands. Without this, the send buffer fills up and causes 'I/O error reading reply' on slow CI runners. This test was removed on 8.1+ but still exists on 7.2 and 8.0. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Cherry-pick of 6ce75cd from unstable. Adds verify_replica_online after wait_for_sync to prevent 'ERR FAILOVER target replica is not online' race condition. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Contributor
Author
|
Closing because it's quite unstable. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0 #3525 +/- ##
===========================
===========================
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks of #3430, #3452, #3241, and #3263 to fix flaky tests on 8.0. Weekly CI context: https://github.com/valkey-io/valkey/actions/runs/24300553351