pair: make QR codes compliant #1110
Open
purpshell wants to merge 2 commits intotulir:mainfrom
Open
Conversation
purpshell
changed the title
|
I tested here and the Codes are invalid. |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QR Codes are no longer compliant since a long time ago. I only found this out by randomly scanning a WhatsApp Web QR code using the native viewer and it actually functioned.
This might be a detection vector to show the user warnings upon trying to log in, but there is no research regarding that at the moment..
You can find this updated logic that includes both the URL prefix and the suffix with the PLATFORM_ID of the device in the module WAWebLinkDeviceQrcode.react