Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReplaces inline companion platform ID and QR string construction in socket pairing with calls to new utility functions Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Socket/socket.ts`:
- Around line 24-31: The named imports from "../Utils" in socket.ts are not
alphabetically sorted causing simple-import-sort/imports to fail; reorder the
specifiers (e.g., buildPairingQRData, configureSuccessfulPairing, Curve,
derivePairingCodeKey, generateLoginNode, generateMdTagPrefix,
generateRegistrationNode, getCompanionPlatformId) into proper alphabetical order
within the import statement so the import list is sorted by identifier name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d972b7b9-334c-4cca-8ee0-ccd19e52b8d1
📒 Files selected for processing (3)
src/Socket/socket.tssrc/Utils/companion-reg-client-utils.tssrc/Utils/index.ts
| advB64: string, | ||
| browser: WABrowserDescription | ||
| ): string => { | ||
| return [ref, noiseKeyB64, identityKeyB64, advB64, getCompanionPlatformId(browser)].join(',') |
There was a problem hiding this comment.
| return [ref, noiseKeyB64, identityKeyB64, advB64, getCompanionPlatformId(browser)].join(',') | |
| return ['https://wa.me/settings/linked_devices#', ref, noiseKeyB64, identityKeyB64, advB64, getCompanionPlatformId(browser)].join(',') |
There was a problem hiding this comment.
I think this has a condition in wa web sources. WAWebNativeCameraQRLinkedDeviceUtils.isNativeCameraQRLinkedDeviceTest. I want to dig more on this to make sure always include this string
There was a problem hiding this comment.
Appears to be a experimental flag 🤔
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
backport of tulir/whatsmeow#1110
Summary by CodeRabbit