Read quoted string when expecting an import#3554
Merged
Conversation
JakeWharton
approved these changes
Mar 23, 2026
Comment on lines
+83
to
+85
| check(startQuote == '"' || startQuote == '\'') { | ||
| unexpected("expected quoted string", location()) | ||
| } |
Collaborator
There was a problem hiding this comment.
This was throwing an exception while throwing an exception. Plus the location is already the default value of the second parameter.
There's a helper that does all this for you:
Suggested change
| check(startQuote == '"' || startQuote == '\'') { | |
| unexpected("expected quoted string", location()) | |
| } | |
| expect(startQuote == '"' || startQuote == '\'') { | |
| "expected quoted string" | |
| } |
Member
Author
There was a problem hiding this comment.
I did miss it, thanks a lot!
oldergod
force-pushed
the
bquenaudon.2026-03-23.parsing
branch
from
5d3a6a6 to
8d73b78
Compare
2 tasks
|
Was it really broken before? Signal was using unquoted imports, and they seemed to be working. |
Member
Author
|
It would break if there was a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3545
We were not parsing quoted strings but the parsing would fail anyway because the parser would be in a broken state after having read a word. So we're making the error more correct now.