import statements in proto files need to be quoted#14669
Closed
JesseWeinstein wants to merge 1 commit intosignalapp:mainfrom
Closed
import statements in proto files need to be quoted#14669JesseWeinstein wants to merge 1 commit intosignalapp:mainfrom
JesseWeinstein wants to merge 1 commit intosignalapp:mainfrom
Conversation
Contributor
Author
|
Wire has now removed the acceptance of unquoted strings -- so this will need to go in once we update to the new version: square/wire#3554 |
Contributor
|
Nice catch! Fix merged into version 8.5. |
Contributor
Author
|
Fixed in commit 72a1a9b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
N/A I have tested my contribution on these devices:
N/A I ensured that all the open issues my contribution fixes are mentioned in the commit message
Description
While Wire (the tool from Square that is used to parse protobuf files) does currently accept unquoted imports, that violates the spec, so it'd be better to avoid relying on it.
I've opened an issue asking them to address this: square/wire#3545