Indexes 9 - Adds messaging on package events to kafka#1356
Open
dcookspi wants to merge 1 commit intoindex-8-spk-build-fixfrom
Open
Indexes 9 - Adds messaging on package events to kafka#1356dcookspi wants to merge 1 commit intoindex-8-spk-build-fixfrom
dcookspi wants to merge 1 commit intoindex-8-spk-build-fixfrom
Conversation
dcookspi
added
enhancement
dcookspi
force-pushed
the
index-9-messaging-to-kafka-feature
branch
3 times, most recently
from
d93a1bd to
d7c1234
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced May 1, 2026
dcookspi
force-pushed
the
index-8-spk-build-fix
branch
from
d2119c4 to
8566af4
Compare
…kafka Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
dcookspi
force-pushed
the
index-9-messaging-to-kafka-feature
branch
from
7d7001c to
e8a9444
Compare
jrray
requested changes
May 7, 2026
Comment on lines
+212
to
+214
| /// Message timeout in milliseconds, defaults to 5000 ms (5 seconds) | ||
| #[serde(default = "default_kafka_timeout_ms")] | ||
| pub timeout_ms: u64, |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Message timeout in milliseconds, defaults to 5000 ms (5 seconds) | |
| #[serde(default = "default_kafka_timeout_ms")] | |
| pub timeout_ms: u64, | |
| /// Message timeout in milliseconds, defaults to 5000 ms (5 seconds) | |
| #[serde(default = "default_kafka_message_timeout_ms")] | |
| pub message_timeout_ms: u64, |
I suggest mirroring the name of the kafka property as a convention to make it more plain what this setting maps to on the kafka side.
| }) | ||
| .to_string(), | ||
| ), | ||
| Duration::from_secs(0), |
Collaborator
There was a problem hiding this comment.
This timeout is for waiting for room in the producer queue, it should be willing to wait some small amount of time as a form of back-pressure. Better to wait a little than fail aggressively.
| "depvar", | ||
| "depver", | ||
| "Deque", | ||
| "derserializer", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds configurable messaging support to
spkso it can send messages after events.This adds support for sending message to kafka when these events occur:
This allows a site to have an external messaging system listen for such messages and take appropriate action, e.g. updating the index on a repo after a new package has been published.
This is the 9th of the chained PRs for adding indexes to spk solves:
new_unchecked()constructors to spk schema objects #1337spk repo indexsubcommand for index generation and updates #1340version_filterfield in index schema #1344