Indexes 8: Fixes the spk build or mkb crash with indexes enabled#1355
Open
dcookspi wants to merge 1 commit intoindex-7-lockfile-for-indexgenfrom
Open
Indexes 8: Fixes the spk build or mkb crash with indexes enabled#1355dcookspi wants to merge 1 commit intoindex-7-lockfile-for-indexgenfrom
dcookspi wants to merge 1 commit intoindex-7-lockfile-for-indexgenfrom
Conversation
68c823f to
8d8583a
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Apr 17, 2026
85050e7 to
d4d81db
Compare
8d8583a to
d4ca8df
Compare
d4d81db to
cddd514
Compare
d4ca8df to
d2119c4
Compare
cddd514 to
5ac3a7b
Compare
Implements downstream_build_requirements function for IndexedPackage. Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
d2119c4 to
8566af4
Compare
jrray
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash that happens when using
spk buildorspk mkbwith indexes enabled. spk would panic becausedownstream_build_requirements()was not implemented forIndexedPackageobjects. Implementing this method using the existing index data fixed the problem.This also refactors the existing downstream_runtime_requirements() method to use a filter function based shared downstream_requirements() method - along the same lines as the exisitng v0/PackageSpec does. Both downstream_*_requirements methods are added to the flatbuffer index tests.
This is the 8th of the chained PRs for adding indexes to spk solves:
new_unchecked()constructors to spk schema objects #1337spk repo indexsubcommand for index generation and updates #1340version_filterfield in index schema #1344