Skip to content

Two simple decoders for Retro computing processors.#130

Open
electrickery wants to merge 7 commits intosigrokproject:masterfrom
electrickery:master
Open

Two simple decoders for Retro computing processors.#130
electrickery wants to merge 7 commits intosigrokproject:masterfrom
electrickery:master

Conversation

@electrickery
Copy link
Copy Markdown

These decoders only add visualisations of address and data values, both read and write. No attempt to add disassembly. This is already very useful for debugging hardware and software as well as a help in annotating disassembled code.

Comment thread README Outdated
@gtoal
Copy link
Copy Markdown

gtoal commented Jan 16, 2026

You might find some useful code for disassembly in hoglet's decoder at https://github.com/hoglet67/6809Decoder
Good to see another person here interested in 6809, that's what I plan to use the logic analyzer on when it gets here.

@electrickery
Copy link
Copy Markdown
Author

@gtoal: Thanks for the pointer, it might be interesting to port this to Python.

Copy link
Copy Markdown

@ivanwick ivanwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for cleanup and formatting

Comment thread decoders/mc6809/__init__.py Outdated
##
## This file is part of the libsigrokdecode project.
##
## Copyright (C) 2014 Daniel Elstner <daniel.kitta@gmail.com>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old copyright notice

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Comment thread decoders/mc6809/pd.py Outdated

import sigrokdecode as srd
from functools import reduce
from common.srdhelper import SrdIntEnum
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SrdIntEnum does not appear to be used (other pd.py also).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Notes on the TMS7000 opcode format and descriptions of both documented and
"undocumented" opcodes are available here:

Details:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this section meant to have some documentation links like the 6809 decoder?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added document reference.

Comment thread decoders/tms7000/pd.py Outdated
from common.srdhelper import SrdIntEnum
import string

#Ann = SrdIntEnum.from_str('Ann', 'ROMDATA')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out code can be removed, also remove import SrdIntEnum.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed & cleaned up.

Comment thread decoders/mc6809/pd.py Outdated
else:
return reduce(lambda a, b: (a << 1) | b, reversed(bus))


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From HACKING

No double-newlines between methods (or anywhere else).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up.

Comment thread decoders/tms7000/pd.py Outdated

import sigrokdecode as srd
from common.srdhelper import SrdIntEnum
import string
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string is not used.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Comment thread decoders/tms7000/__init__.py Outdated
##
## This file is part of the libsigrokdecode project.
##
## Copyright (C) 2014 Daniel Elstner <daniel.kitta@gmail.com>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old copyright notice

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants