Skip to content

Fix duplicate global IDs on carousel items #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
clxmpfeffermann wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Fix duplicate global IDs on carousel items #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/components/carousel/carousel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import type SlCarouselItem from '../carousel-item/carousel-item.component.js';
export default class SlCarousel extends ShoelaceElement {
static styles: CSSResultGroup = [componentStyles, styles];
static dependencies = { 'sl-icon': SlIcon };
static idUniqueCounter = 0;

/** When set, allows the user to navigate the carousel in the same direction indefinitely. */
@property({ type: Boolean, reflect: true }) loop = false;
Expand Down Expand Up @@ -96,6 +97,7 @@ export default class SlCarousel extends ShoelaceElement {
private readonly localize = new LocalizeController(this);
private mutationObserver: MutationObserver;
private pendingSlideChange = false;
private idUniquePrefix = `sl-carousel${++SlCarousel.idUniqueCounter}-`;

connectedCallback(): void {
super.connectedCallback();
Expand Down Expand Up @@ -292,8 +294,11 @@ export default class SlCarousel extends ShoelaceElement {

for (const entry of entries) {
const slide = entry.target;
slide.toggleAttribute('inert', !entry.isIntersecting);
slide.classList.toggle('--in-view', entry.isIntersecting);
if (this.loop && slide.hasAttribute('data-clone')) {
continue;
}
slide.toggleAttribute('inert', !entry.isIntersecting);
slide.setAttribute('aria-hidden', entry.isIntersecting ? 'false' : 'true');
}

Expand Down Expand Up @@ -371,10 +376,10 @@ export default class SlCarousel extends ShoelaceElement {
slide.setAttribute('aria-label', this.localize.term('slideNum', index + 1));

if (this.pagination) {
slide.setAttribute('id', `slide-${index + 1}`);
slide.setAttribute('id', `${this.idUniquePrefix}slide-${index + 1}`);
slide.setAttribute('role', 'tabpanel');
slide.removeAttribute('aria-label');
slide.setAttribute('aria-labelledby', `tab-${index + 1}`);
slide.setAttribute('aria-labelledby', `${this.idUniquePrefix}tab-${index + 1}`);
}

if (slide.hasAttribute('data-clone')) {
Expand Down Expand Up @@ -405,12 +410,22 @@ export default class SlCarousel extends ShoelaceElement {
lastSlides.reverse().forEach((slide, i) => {
const clone = slide.cloneNode(true) as HTMLElement;
clone.setAttribute('data-clone', String(slides.length - i - 1));
clone.removeAttribute('id');
clone.removeAttribute('role');
clone.removeAttribute('aria-labelledby');
clone.setAttribute('inert', '');
clone.setAttribute('aria-hidden', 'true');
this.prepend(clone);
});

firstSlides.forEach((slide, i) => {
const clone = slide.cloneNode(true) as HTMLElement;
clone.setAttribute('data-clone', String(i));
clone.removeAttribute('id');
clone.removeAttribute('role');
clone.removeAttribute('aria-labelledby');
clone.setAttribute('inert', '');
clone.setAttribute('aria-hidden', 'true');
this.append(clone);
});
}
Expand Down Expand Up @@ -630,8 +645,8 @@ export default class SlCarousel extends ShoelaceElement {
'carousel__pagination-item--active': isActive
})}"
role="tab"
id="tab-${index + 1}"
aria-controls="slide-${index + 1}"
id="${this.idUniquePrefix}tab-${index + 1}"
aria-controls="${this.idUniquePrefix}slide-${index + 1}"
aria-selected="${isActive ? 'true' : 'false'}"
aria-label="${isActive
? this.localize.term('slideNum', index + 1)
Expand Down