Fix duplicate global IDs on carousel items#2459
Draft
clxmpfeffermann wants to merge 1 commit intoshoelace-style:nextfrom
Draft
Fix duplicate global IDs on carousel items#2459clxmpfeffermann wants to merge 1 commit intoshoelace-style:nextfrom
clxmpfeffermann wants to merge 1 commit intoshoelace-style:nextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2458
Fixes duplicate global IDs on
sl-carousel-itemby prefixing the IDs with a tag that is unique per instance.I removed the IDs and aria-attributes from cloned slides. Further, I thought it was appropriate to make them permanently inert/aria-hidden because they are never interacted with and only exist for a smooth visual transition.
Potentially breaking:
slide-1,slide-2, etc.