Skip to content

RC 0.0.47#53

Merged
technophile-04 merged 38 commits intomainfrom
rc-0.0.47
Jun 14, 2024
Merged

RC 0.0.47#53
technophile-04 merged 38 commits intomainfrom
rc-0.0.47

Conversation

@carletex
Copy link
Member

@carletex carletex commented Jun 14, 2024

Since we have a few things to merge, we thought it'd be nice to test a couple of things:

  1. Use of release candidate branch (that we will merge to main) and we can test all the changes together
  2. Publishing a beta package in npm.

This PR includes #2 #3 #14 #45 #47 #50 #51

dependabot bot and others added 30 commits April 25, 2024 10:30
@dependabot
Bump semver from 5.7.1 to 5.7.2
7c3e5cc 
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump tar from 6.1.13 to 6.2.1
2784d02 
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.13...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump ip from 2.0.0 to 2.0.1
7cf8a95 
Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@technophile-04
remove handling of generated dir and yarn.lock file
9b86106
@technophile-04
allow undefined args to be passed by extensions
6d88840
@technophile-04
simplify copyBaseFiles
a5cc76f
@technophile-04
remove passing of extra option argument from copyBaseFiles
e95f6b7
@dependabot
Bump braces from 3.0.2 to 3.0.3
99608a0 
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@technophile-04
remove logic nested-extension + extends extension
21c75a1
@technophile-04
remove dangling TODO
962db91
@technophile-04
tidy up extension-tree.ts file
e7b5b33
@technophile-04
remove nested and extending section from RFC.md file
8e4323c
@technophile-04
remove handlebars from dependency
91d3d33
@rin-st
feat: linkr2
89401d4
@rin-st
fix: change base branch
faba4af
@rin-st
chore: changeset
48c59fd
@rin-st
chore: changeset message
bab3675
@technophile-04
remove husky
8f54794 
removed by running following command:

yarn remove husky && git config --unset core.hooksPath
@technophile-04
add and configure lefthook
2746eca
@technophile-04
remove lint-staged
9f61c72
@rin-st
chore: remove @types/listr
48f8fde
@technophile-04
remvoe pinst
23462be
@rin-st
fix: render options
51831ed
@technophile-04
don't symlink yarn.lock in dev mode
3660a05
@technophile-04
don't symlink deployedContracts.ts in dev mode
4ac42dc
@carletex
Merge branch 'dependabot/npm_and_yarn/semver-5.7.2' into rc-0.0.47
0bb4055
@carletex
Merge branch 'dependabot/npm_and_yarn/tar-6.2.1' into rc-0.0.47
583a453
@carletex
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/ip-2.0.1…
16f00b8 
…' into rc-0.0.47
@carletex
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/braces-3…
e75cce0 
….0.3' into rc-0.0.47
@carletex
Merge remote-tracking branch 'origin/fix-spamming-message' into rc-0.…
fdb7f70 
…0.47
rin-st
rin-st reviewed Jun 14, 2024
View reviewed changes
@carletex
Copy link
Member Author

carletex commented Jun 14, 2024

Beta version published on:

npx create-eth@0.0.47-beta.1

More info about pre-releases here: https://github.com/changesets/changesets/blob/main/docs/prereleases.md (we should all of this stuff on #6) . Also add the more verbose option to use npx: npm create eth@<version> (the space between create and eth should be there, not a typo.)

@carletex
Copy link
Member Author

carletex commented Jun 14, 2024

Thinking about merging vs squash and merging here (with this release branch model).

I think if squash and merge, the existing PRs won't close (but they history will be clean). If we just merge, the PRs will close... but the git history 😓

But then...I'm thinking that if we are using this system, we should be merging always against a release branch, not main.... so we shouldn't have this problem, right?

So maybe test this, squash & merge... and close the PRs manually?

@rin-st
Copy link
Member

rin-st commented Jun 14, 2024 •
edited
Loading

If we just merge, the PRs will close...

Not sure I understand how it works. Why they will close? Because all the commits will already be on main? If yes, everything else seems reasonable. Only one question

But then...I'm thinking that if we are using this system, we should be merging always against a release branch, not main.... so we shouldn't have this problem, right?

We don't know at the start if it will be patch, minor or major. So maybe use dev branch? Merge to dev and then torc branches from dev when ready? After it squash rc to main.

btw, A new commit added to #45 . Not sure it's completed though

@carletex
Copy link
Member Author

carletex commented Jun 14, 2024

Why they will close? Because all the commits will already be on main?

Yep!

We don't know at the start if it will be patch, minor or major. So maybe use dev branch? Merge to dev and then torc branches from dev when ready? After it squash rc to main.

Yeah, not sure. Let's keep exploring as we go and decide. Thanks!

btw, A new commit added to #45 . Not sure it's completed though

Renaming the file? Yep, that was added here.

Also added the eip712 curated extension in this PR.

@rin-st
Copy link
Member

rin-st commented Jun 14, 2024

Renaming the file? Yep, that was added here.

hmm, I don't see that commit and see this in files tree

image

Also added the eip712 curated extension in this PR.

nit: maybe name it eip-712 instead of eip712? So it will be consistent with branch name on extensions and with naming here?

tested #50, #51, -e eip712 and also #45 and everything works well for me

@carletex
Copy link
Member Author

carletex commented Jun 14, 2024

hmm, I don't see that commit and see this in files tree

Oh sorry, created this after Shiv pushed, but forgot to pull it first :D Thanks for adding it Shiv!

nit: maybe name it eip-712 instead of eip712? So it will be consistent with branch name on extensions and with naming here?

Yeah, this makes sense.

technophile-04
technophile-04 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@technophile-04 technophile-04 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nicely and everything works nicely !! also all the extensions, also tried out :

 npx create-eth@0.0.47-beta.1 -e technophile-04/eip-5792:foundry

works nicely ! Thanks all !!

@technophile-04 technophile-04 merged commit bfa6b71 into main Jun 14, 2024
@technophile-04 technophile-04 deleted the rc-0.0.47 branch June 14, 2024 17:30
This was referenced Jun 17, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rin-st rin-st rin-st approved these changes

@technophile-04 technophile-04 technophile-04 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carletex @rin-st @technophile-04