Update developer guide with the new create-eth workflow#59
Merged
technophile-04 merged 4 commits intomainfrom Jun 21, 2024
Merged
Update developer guide with the new create-eth workflow#59technophile-04 merged 4 commits intomainfrom
technophile-04 merged 4 commits intomainfrom
Conversation
Closed
Collaborator
technophile-04
left a comment
There was a problem hiding this comment.
Thanks @Pabl0cks !! This is nice!! Added a couple comments
Also we should update this and point it to core-extension instead of RFC-extension:
Collaborator
Author
|
Thanks a lot for your review @technophile-04 and @carletex !! ♥ Just pushed the review tweaks and changed the "RFC-extensions" reference to "core-extensions" 🙌 |
technophile-04
approved these changes
Jun 21, 2024
Collaborator
technophile-04
left a comment
There was a problem hiding this comment.
I think this looks great! Thanks Pablo!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the workflow to backmerge
scaffold-eth/scaffold-eth-2:mainbranch intoscaffold-eth/create-eth:mainbranch.Based on #12 guidelines
Closes #6