Skip to content

Update developer guide with the new create-eth workflow#59

Merged
technophile-04 merged 4 commits intomainfrom
developer-guide
Jun 21, 2024
Merged

Update developer guide with the new create-eth workflow#59
technophile-04 merged 4 commits intomainfrom
developer-guide

Conversation

@Pabl0cks
Copy link
Collaborator

@Pabl0cks Pabl0cks commented Jun 18, 2024

Updating the workflow to backmerge scaffold-eth/scaffold-eth-2:main branch into scaffold-eth/create-eth:main branch.

Based on #12 guidelines

Closes #6

@technophile-04 technophile-04 mentioned this pull request Jun 19, 2024
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pabl0cks !! This is nice!! Added a couple comments

Also we should update this and point it to core-extension instead of RFC-extension:

It's highly recommended that you go through [RFC-extensions.md](RFC-extensions.md) to understand the template API to create extensions. We use a custom template API to allow extensions to modify any file inside the `templates/` folder. While flexible and powerful, it requires developers to understand how it works. It's JS based, so there's no new technology needed to understand and use it.

@Pabl0cks Pabl0cks marked this pull request as ready for review June 19, 2024 21:22
@Pabl0cks
Copy link
Collaborator Author

Thanks a lot for your review @technophile-04 and @carletex !! ♥

Just pushed the review tweaks and changed the "RFC-extensions" reference to "core-extensions" 🙌

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Thanks Pablo!!

@technophile-04 technophile-04 merged commit dad22ac into main Jun 21, 2024
@technophile-04 technophile-04 deleted the developer-guide branch June 21, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating developer guide

3 participants