resolve: Set correct parent and expansion for self declarations#156353
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom May 9, 2026
Merged
resolve: Set correct parent and expansion for self declarations#156353rust-bors[bot] merged 1 commit intorust-lang:mainfrom
self declarations#156353rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
r? @mu001999 |
petrochenkov
added
the
beta-nominated
Contributor
Author
|
I'll stable-nominate as well, because #146972 is on stable, but this certainly doesn't deserve a point release. |
petrochenkov
added
the
stable-nominated
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
@petrochenkov am I understanding correctly that the backport nominations are largely to avoid the ICE? |
Contributor
Author
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 9, 2026
resolve: Set correct parent and expansion for `self` declarations Follow up to rust-lang#146972 and rust-lang#154313. The `parent` seems to not be used yet, it will ICE if used (rust-lang#156185 uses it). The `expn_id` is only relevant to macros 2.0, I won't bother coming up with a test.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 9, 2026
Rollup of 5 pull requests Successful merges: - #156354 (Update example code of `std::array::from_fn`) - #156359 (use `cfg_select!` in integer `{to, from}_{le, be}`) - #156124 (Make stable hashing names consistent (part 2)) - #156235 (fix: Guard SizeSkeleton::compute against stack overflow) - #156353 (resolve: Set correct parent and expansion for `self` declarations)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #146972 and #154313.
The
parentseems to not be used yet, it will ICE if used (#156185 uses it).The
expn_idis only relevant to macros 2.0, I won't bother coming up with a test.