Rollup of 5 pull requests by jhpratt · Pull Request #156361 · rust-lang/rust

jhpratt · 2026-05-09T13:28:00Z

Successful merges:

Update example code of std::array::from_fn #156354 (Update example code of std::array::from_fn)
use cfg_select! in integer {to, from}_{le, be} #156359 (use cfg_select! in integer {to, from}_{le, be})
Make stable hashing names consistent (part 2) #156124 (Make stable hashing names consistent (part 2))
fix: Guard SizeSkeleton::compute against stack overflow #156235 (fix: Guard SizeSkeleton::compute against stack overflow)
resolve: Set correct parent and expansion for self declarations #156353 (resolve: Set correct parent and expansion for self declarations)

r? @ghost

Create a similar rollup

Likewise for the corresponding incremental test. Part of MCP 983.

Part of MCP 983.

Plus two related methods. Part of MCP 983.

Part of MCP 983.

Including the `stable_hasher` attribute and the `HashStableMode` enum. Part of MCP 983.

And the `abi_hash` method as `abi_stable_hash`. Part of MCP 983.

Part of MCP 983.

The explanation given for the non-derive use is incorrect.

Update example code of `std::array::from_fn` Since the std::array::from_fn feature has been stabilized since version 1.91.1, the comment stating that it is not stable has been removed. Additionally, the related example code has been modified into a simple example that is easy to understand. Close rust-lang#156102

…t, r=chenyukang use `cfg_select!` in integer `{to, from}_{le, be}` A simple bit of cleanup.

@jieyouxu

…, r=jieyouxu Make stable hashing names consistent (part 2) This PR finishes the implementation of MCP 893. r? @jieyouxu

…_fix, r=adwinwhite fix: Guard SizeSkeleton::compute against stack overflow Fixes rust-lang#156137 Fix: extract the recursion into a private `compute_inner` that carries a depth counter. When depth exceeds the crate's recursion limit, return `LayoutError::Unknown` and let the existing transmute size-check produce a normal error instead of crashing. A regression test is included in `tests/ui/transmute/`.

resolve: Set correct parent and expansion for `self` declarations Follow up to rust-lang#146972 and rust-lang#154313. The `parent` seems to not be used yet, it will ICE if used (rust-lang#156185 uses it). The `expn_id` is only relevant to macros 2.0, I won't bother coming up with a test.

jhpratt · 2026-05-09T13:28:10Z

@bors r+ rollup=never p=5

rust-bors · 2026-05-09T13:28:13Z

📌 Commit c32a2cd has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-05-09T17:08:59Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 15m 53s
Pushing 29155a4 to main...

rust-timer · 2026-05-09T17:10:29Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#156124	Make stable hashing names consistent (part 2)	`8788f02f2386a025039a8e382dc2b145924d0c89` (link)
#156235	fix: Guard SizeSkeleton::compute against stack overflow	`51ea4cc92504a4b3059365ce9ca5d84beff29a9a` (link)
#156353	resolve: Set correct parent and expansion for `self` declar…	`30343bacc14a18db52d7610b570d126ed835eb5e` (link)
#156354	Update example code of `std::array::from_fn`	`10331e706cda0ce6563a2a493c38be3bd8869ccc` (link)
#156359	use `cfg_select!` in integer `{to, from}_{le, be}`	`fd15a9e24716f9ed334b8c9154e7b8d5010d4441` (link)

previous master: 0490dd9385

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-05-09T17:12:21Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0490dd9 (parent) -> 29155a4 (this PR)

Test differences

Show 6496 test diffs

Stage 0

stable_hash::tests::test_attribute_permutation: [missing] -> pass (J1)
stable_hash::tests::test_hash_bit_matrix: [missing] -> pass (J1)
stable_hash::tests::test_hash_bit_set: [missing] -> pass (J1)
stable_hash::tests::test_isize_compression: [missing] -> pass (J1)
stable_hasher::tests::test_attribute_permutation: pass -> [missing] (J1)
stable_hasher::tests::test_hash_bit_matrix: pass -> [missing] (J1)
stable_hasher::tests::test_hash_bit_set: pass -> [missing] (J1)
stable_hasher::tests::test_isize_compression: pass -> [missing] (J1)

Stage 1

stable_hash::tests::test_attribute_permutation: [missing] -> pass (J0)
stable_hash::tests::test_hash_bit_matrix: [missing] -> pass (J0)
stable_hash::tests::test_hash_bit_set: [missing] -> pass (J0)
stable_hash::tests::test_isize_compression: [missing] -> pass (J0)
stable_hasher::tests::test_attribute_permutation: pass -> [missing] (J0)
stable_hasher::tests::test_hash_bit_matrix: pass -> [missing] (J0)
stable_hasher::tests::test_hash_bit_set: pass -> [missing] (J0)
stable_hasher::tests::test_isize_compression: pass -> [missing] (J0)
[incremental] tests/incremental/span_hash_stable/main.rs: pass -> [missing] (J1)
[incremental] tests/incremental/stable_hash_span/main.rs: [missing] -> pass (J1)
[ui] tests/ui-fulldeps/hash-stable-is-unstable.rs: pass -> [missing] (J1)
[ui] tests/ui-fulldeps/stable-hash-is-unstable.rs: [missing] -> pass (J1)
[ui] tests/ui/transmute/recursive-size-skeleton.rs: [missing] -> pass (J1)

Stage 2

[incremental] tests/incremental/span_hash_stable/main.rs: pass -> [missing] (J2)
[incremental] tests/incremental/stable_hash_span/main.rs: [missing] -> pass (J2)
[ui] tests/ui/transmute/recursive-size-skeleton.rs: [missing] -> pass (J3)
[ui] tests/ui-fulldeps/hash-stable-is-unstable.rs: pass -> [missing] (J4)
[ui] tests/ui-fulldeps/stable-hash-is-unstable.rs: [missing] -> pass (J4)
[incremental] tests/incremental/span_hash_stable/main.rs: ignore (gcc backend is marked as ignore) -> [missing] (J5)
[incremental] tests/incremental/stable_hash_span/main.rs: [missing] -> ignore (gcc backend is marked as ignore) (J5)

Additionally, 6468 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 29155a4cd6e9ecddf1ce1c539711df678923d69a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-mingw: 2h -> 2h 31m (+25.4%)
dist-x86_64-netbsd: 1h 9m -> 1h 26m (+25.2%)
dist-i686-msvc: 2h 23m -> 1h 49m (-23.8%)
dist-android: 22m 52s -> 27m 53s (+21.9%)
x86_64-gnu-llvm-22-3: 1h 35m -> 1h 54m (+19.8%)
dist-various-2: 44m 29s -> 36m (-19.1%)
x86_64-gnu-llvm-22-2: 1h 38m -> 1h 22m (-16.1%)
x86_64-gnu-llvm-21-1: 1h 18m -> 1h 9m (-10.7%)
test-various: 1h 58m -> 2h 10m (+10.6%)
dist-x86_64-apple: 1h 59m -> 2h 11m (+9.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-09T17:51:29Z

Finished benchmarking commit (29155a4): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.7%	[4.7%, 4.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[-2.2%, 4.7%]	2

Cycles

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.416s -> 498.758s (0.27%)
Artifact size: 397.18 MiB -> 397.18 MiB (-0.00%)

nnethercote and others added 18 commits May 8, 2026 14:37

Rename the span_hash_stable method as stable_hash_span.

ad6647f

Likewise for the corresponding incremental test. Part of MCP 983.

Rename the StableHashingContext struct as StableHashState.

eab49f5

Part of MCP 983.

Rename the HashingControls struct as StableHashControls.

1869ac8

Plus two related methods. Part of MCP 983.

Rename rustc_data_structures::stable_hasher as stable_hash.

33cd10a

Part of MCP 983.

Rename rustc_macros::hash_stable as stable_hash.

fd7da21

Part of MCP 983.

Rename various things relating to the StableHash derive macros.

45efffc

Including the `stable_hasher` attribute and the `HashStableMode` enum. Part of MCP 983.

Rename AbiHashStable as AbiStableHash.

e25e44b

And the `abi_hash` method as `abi_stable_hash`. Part of MCP 983.

Rename tests/ui-fulldeps/hash-stable-is-unstable.*

d24bd32

Part of MCP 983.

Fix a comment.

6e24214

The explanation given for the non-derive use is incorrect.

resolve: Set correct parent and expansion for self declarations

16729bc

chore : remove not stable explain and edit code explain

5d7f9b5

Guard SizeSkeleton::compute against stack overflow

7a900df

use cfg_select! in {to, from}_{le, be}

6c79906

Rollup merge of rust-lang#156359 - folkertdev:to-from-be-le-cfg-selec…

2976a2c

…t, r=chenyukang use `cfg_select!` in integer `{to, from}_{le, be}` A simple bit of cleanup.

Rollup merge of rust-lang#156124 - nnethercote:StableHash-renamings-2…

71e64b9

…, r=jieyouxu Make stable hashing names consistent (part 2) This PR finishes the implementation of MCP 893. r? @jieyouxu

rust-bors Bot added the rollup A PR which is a rollup label May 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2026

rust-bors Bot mentioned this pull request May 9, 2026

Consider Result<T, Uninhabited> and ControlFlow<Uninhabited, T> to be equivalent to T for must use lint #148214

Open

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2026

rust-bors Bot merged commit 29155a4 into rust-lang:main May 9, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone May 9, 2026

jhpratt deleted the rollup-G3Jg88X branch May 9, 2026 17:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#156361

Rollup of 5 pull requests#156361
rust-bors[bot] merged 18 commits intorust-lang:mainfrom
jhpratt:rollup-G3Jg88X

jhpratt commented May 9, 2026

Uh oh!

jhpratt commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 9, 2026

Uh oh!

Uh oh!

rust-timer commented May 9, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

jhpratt commented May 9, 2026

Uh oh!

jhpratt commented May 9, 2026

Uh oh!

rust-bors Bot commented May 9, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 9, 2026

Uh oh!

Uh oh!

rust-timer commented May 9, 2026

Uh oh!

github-actions Bot commented May 9, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 9, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants