Skip to content

Use URDF_MAJOR_VERSION for SOVERSION #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-rivero wants to merge 1 commit into
base: rolling
Choose a base branch
from
+1 −1
Open

Use URDF_MAJOR_VERSION for SOVERSION #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion urdf_parser/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ macro(add_urdfdom_library)
endif()
set_target_properties(${add_urdfdom_library_LIBNAME} PROPERTIES
DEFINE_SYMBOL URDFDOM_EXPORTS
SOVERSION ${URDF_MAJOR_MINOR_VERSION})
SOVERSION ${URDF_MAJOR_VERSION})
Copy link
Copy Markdown
Contributor

@saikishor saikishor Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SOVERSION ${URDF_MAJOR_VERSION})
VERSION ${URDF_MAJOR_MINOR_VERSION}
SOVERSION ${URDF_MAJOR_VERSION})

Should we also use the VERSION for the target?

https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html

Copy link
Copy Markdown
Contributor

@scpeters scpeters Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think @j-rivero?

endmacro()

if(TARGET console_bridge::console_bridge)
Expand Down