schema_registry/protobuf: fix MESSAGE_REMOVED for removed map fields#30400
Open
QueLLL wants to merge 1 commit intoredpanda-data:devfrom
Open
schema_registry/protobuf: fix MESSAGE_REMOVED for removed map fields#30400QueLLL wants to merge 1 commit intoredpanda-data:devfrom
QueLLL wants to merge 1 commit intoredpanda-data:devfrom
Conversation
Collaborator
Retry command for Build#84210please wait until all jobs are finished before running the slash command |
Collaborator
nguyen-andrew
previously approved these changes
May 8, 2026
Member
nguyen-andrew
left a comment
There was a problem hiding this comment.
Thanks for reporting and fixing this! LGTM
Member
|
Looks like lint is failing, could you run |
634777f to
ae7d0a0
Compare
ae7d0a0 to
b80d657
Compare
Author
Done, thanks! |
b80d657 to
c013b6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf map fields are represented in descriptors as compiler-generated
nested
*Entrymessage types. Redpanda schema registry was comparing those map entry typesas regular nested messages during compatibility checks, so removing a map
field could incorrectly fail with
MESSAGE_REMOVEDSkip protobuf map entry types when checking nested message compatibility.
This matches Confluent Schema Registry behavior and fixes map field removal
compatibility for all protobuf map key/value combinations.
Fixes #30374
Backports Required
Release Notes
Bug Fixes
with
MESSAGE_REMOVEDwhen a map field is removed.