Skip to content

Builds: add tests for delete_old_build_objects and fix KeyError in _delete_builds#12820

Merged
stsewd merged 3 commits intodelete-old-build-objectsfrom
copilot/sub-pr-12800
Feb 27, 2026
Merged

Builds: add tests for delete_old_build_objects and fix KeyError in _delete_builds#12820
stsewd merged 3 commits intodelete-old-build-objectsfrom
copilot/sub-pr-12800

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

  • Write tests for delete_old_build_objects function
  • Fix KeyError in _delete_builds when no builds are deleted
  • Use assert foo == bar syntax instead of self.assertEqual in TestDeleteOldBuildObjects

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ilds

Co-authored-by: stsewd <4975310+stsewd@users.noreply.github.com>
Copilot AI changed the title [WIP] Delete old build objects from database Builds: add tests for delete_old_build_objects and fix KeyError in _delete_builds Feb 26, 2026
@stsewd
Copy link
Member

stsewd commented Feb 26, 2026

@copilot code review[agent] use the assert foo == bar syntax

Co-authored-by: stsewd <4975310+stsewd@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 27, 2026

@copilot code review[agent] use the assert foo == bar syntax

Done in 724f4c2 — replaced all self.assertEqual calls in TestDeleteOldBuildObjects with assert foo == bar syntax.

@stsewd stsewd marked this pull request as ready for review February 27, 2026 00:12
@stsewd stsewd requested a review from a team as a code owner February 27, 2026 00:12
@stsewd stsewd self-requested a review February 27, 2026 00:12
@stsewd stsewd merged commit 428319a into delete-old-build-objects Feb 27, 2026
1 of 2 checks passed
@stsewd stsewd deleted the copilot/sub-pr-12800 branch February 27, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants