fix(carousel,galleria,timeline): enable generic type inference for value and slots#8490
Open
YevheniiKotyrlo wants to merge 1 commit intoprimefaces:masterfrom
Open
Conversation
…lue and slots Make CarouselProps/Slots, GalleriaProps/Slots, and TimelineProps/Slots generic on T, inferred from the value binding. Replace DefineComponent with generic constructors for type inference. Carousel item slot data, Galleria item/caption/thumbnail slots, and Timeline content/opposite/marker/connector slots all become T.
This was referenced Mar 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #8487
Carousel, Galleria, and Timeline use
anyfor their value arrays and slot scoped data. Developers get no IDE autocomplete and no compile-time safety when rendering items in these data-display components.Same root cause as #8442 —
DefineComponent's no-arg constructor prevents generic inference. Same fix pattern as #8444 (DataTable/DatePicker).Related: #7426, #6041
Reproducer: StackBlitz —
bun run type-check(0 errors, typo undetected) →bun run patch && bun run type-check(TS2339 catches it)Problem
After this fix, TypeScript infers
Tfrom the:valuebinding and flows it to all slots:Changes
For each component:
[Component]Props<T = any>—value: T[][Component]Slots<T = any>— all data-bearing slot parameters becomeTnew <T = any>(props: [Component]Props<T>)with$slots: [Component]Slots<T>What gets typed
#itemdataanyT#item/#caption/#thumbnailitemanyT#content/#opposite/#marker/#connectoritemanyTScope / Impact
Tdefaults toanyVerification
pnpm run format:checkpnpm run lintpnpm run test:unitpnpm run build:packagesSeries
This is part of a series bringing generic type inference to all PrimeVue data components:
ofprop)After this series, every PrimeVue component with a collection prop will infer
Tfrom the binding and flow it to slots — giving developers full IDE autocomplete and compile-time type safety in templates.