fix(select,multiselect,listbox): enable generic type inference for options and slots#8484
Open
YevheniiKotyrlo wants to merge 1 commit intoprimefaces:masterfrom
Open
Conversation
This was referenced Mar 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #8482
Select, MultiSelect, and Listbox use
anyfor theiroptionsprop and all slot scoped data. Developers get no IDE autocomplete and no compile-time safety when working with option slots — the most common interaction pattern for these components.Same root cause as #8442 —
DefineComponent's no-arg constructor prevents generic inference. Same fix pattern as #8444 (DataTable/DatePicker).Related: #7426, #6041
Reproducer: StackBlitz — run
bun run type-checkin terminal (0 errors — typo undetected), thenbun run patch && bun run type-check(TS2339 — typo caught)Problem
After this fix, TypeScript infers
T = Userfrom the:optionsbinding and propagates it to all slots and callbacks:The template code is identical — only the type inference changes.
Changes
For each component (Select, MultiSelect, Listbox):
[Component]Props<T = any>—options: T[], callback params(data: T) => ...[Component]Slots<T = any>—option: T,options: T[]in header/footer/loader slotsnew <T = any>(props: [Component]Props<T>)with$slots: [Component]Slots<T>modelValuestaysany— whenoptionValueis set, the value is the extracted scalar (e.g.,string), not the option object (e.g.,User). Typing both asTwould cause false positives across every consumer that usesoptionValue.What gets typed
#optionslotoptionanyT#header/#footerslotoptionsany[]T[]#optiongroupslotoptionanyToptionLabelcallback paramanyToptionValuecallback paramanyToptionDisabledcallback paramanyTmodelValueanyany(unchanged — see above)Scope / Impact
Tdefaults toanyVerification
vue-tsc --noEmitwithstrictTemplatesSeries
This is part of a series bringing generic type inference to all PrimeVue data components:
ofprop)After this series, every PrimeVue component with a collection prop will infer
Tfrom the binding and flow it to slots — giving developers full IDE autocomplete and compile-time type safety in templates.