Skip to content

All settings within same filterable containers are visible when search is matched #37183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanc7278 wants to merge 4 commits into
base: master
Choose a base branch
from
+32 −0
Open

All settings within same filterable containers are visible when search is matched #37183

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a87f56
All settings within same filterable containers are visible when searc…
nathanc7278 Apr 2, 2026
9d9cc95
reformatted using dotnet
nathanc7278 Apr 2, 2026
58d174b
make only horizontal row visible
nathanc7278 Apr 4, 2026
596722a
added newlines
nathanc7278 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions osu.Game/Overlays/Settings/SettingsSection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@

private bool matchingFilter = true;

private static void showIFilterableChildren(Drawable drawable)
{
if (drawable is IFilterable filterable)
filterable.MatchingFilter = true;
if (drawable is IContainerEnumerable<Drawable> container)
{
foreach (var child in container.Children)
showIFilterableChildren(child);
}
}
public bool MatchingFilter
{
get => matchingFilter;
Expand All @@ -51,6 +61,12 @@

matchingFilter = value;

if (matchingFilter && FilteringActive)
{
foreach (var child in Children)
showIFilterableChildren(child);
}

if (IsPresent != wasPresent)
Invalidate(Invalidation.Presence);
}
Expand Down
Loading