All settings within same filterable containers are visible when search is matched#37183
All settings within same filterable containers are visible when search is matched#37183nathanc7278 wants to merge 2 commits intoppy:masterfrom
Conversation
a6b1b38 to
9d9cc95
Compare
|
I don't get it. Why does "delete" show the whole maintenance section? Why does "export" show "Learn more about lazer"? This doesn't make sense. If we're doing this kind of approach, unrelated buttons/controls need to be dimmed or something. In the linked issue, I proposed keeping the other buttons visible for that specific control, because they are horizontally dependent on each other for alignment. |
Thanks for clarifying. I will take a look at how to only show buttons that are in the same horizontal layer. |
Fixes #35917
Modified the
MatchingFiltersetter inSettingsSection.csto additionally markMatchingFilterattribute of child elements to true when a setting is being searched. Added a private helper functionshowIFilterableChildrenthat recurses onIContainerEnumerable<Drawable>.Before:
before.2.mp4
After:
after.1.mp4
A big downside of this approach is that it makes the screens a bit cluttered when searching for more popular options like "cursor"