Skip to content

chore: upgrade borp to v1.0.0 #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tony133 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −5
Open

chore: upgrade borp to v1.0.0 #2395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b7ba00
chore: upgrade borp to v1.0.0
Tony133 Feb 20, 2026
567f6d4
test: rename core.transpiled.test.ts and update
Tony133 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@types/node": "^25.0.3",
"airtap": "5.0.0",
"bole": "^5.0.5",
"borp": "^0.21.0",
"borp": "^1.0.0",
"bunyan": "^1.8.14",
"debug": "^4.3.4",
"docsify-cli": "^4.4.4",
Expand Down
12 changes: 8 additions & 4 deletions test/transport/core.transpiled.test.ts → test/transport/core.transpiled.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
import test from 'node:test'
import assert from 'node:assert'
import * as os from 'node:os'
import { join } from 'node:path'
import { join, dirname } from 'node:path'
import fs from 'node:fs'
import * as url from 'node:url'

import { watchFileCreated } from '../helper'
import pino from '../../'
import { fileURLToPath } from 'node:url'
import { watchFileCreated } from '../helper.js'
import pino from '../../pino.js'

const __filename = fileURLToPath(import.meta.url)
const __dirname = dirname(__filename)
Copy link
Copy Markdown
Member

@mcollina mcollina Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Contributor Author

@Tony133 Tony133 Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

I modified and renamed the core.transpiled.test.ts file because it was giving an error in the pipeline see screenshot and error pipeline: https://github.com/pinojs/pino/actions/runs/22222475586/job/64281005297

screenshot-error

Copy link
Copy Markdown
Member

@mcollina mcollina Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import.meta.dirname and import.meta.filename exists

Copy link
Copy Markdown
Contributor Author

@Tony133 Tony133 Feb 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import.meta.dirname and import.meta.filename exists

I checked, I added them because these tests were failing ( see screenshot )

screenshot-error screenshot-test-error

in fact removing them gives me errors in the tests


const readFile = fs.promises.readFile

const { pid } = process
const hostname = os.hostname()

// A subset of the test from core.test.js, we don't need all of them to check for compatibility
function runTests (esVersion: string): void {
function runTests (esVersion) {
test(`(ts -> ${esVersion}) pino.transport with file`, async (t) => {
const destination = join(
os.tmpdir(),
Expand Down
Loading