Open
Conversation
mcollina
requested changes
Feb 21, 2026
| import pino from '../../pino.js' | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url) | ||
| const __dirname = dirname(__filename) |
Contributor
Author
There was a problem hiding this comment.
Why?
I modified and renamed the core.transpiled.test.ts file because it was giving an error in the pipeline see screenshot and error pipeline: https://github.com/pinojs/pino/actions/runs/22222475586/job/64281005297
Member
There was a problem hiding this comment.
import.meta.dirname and import.meta.filename exists
Contributor
Author
There was a problem hiding this comment.
import.meta.dirname and import.meta.filename exists
I checked, I added them because these tests were failing ( see screenshot )
in fact removing them gives me errors in the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposals:
borpdependency from^0.21.0to^1.0.0( see here: https://github.com/mcollina/borp/releases/tag/v1.0.0 )core.transpiled.test.tstocore.transpiled.test.mjscore.transpiled.test.mjs