Skip to content

Add sudo examples for inspecting inner call results #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Devpen787 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add sudo examples for inspecting inner call results #2216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 50 additions & 10 deletions testing/integration-tests/src/full_client/frame/sudo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type Call = runtime_types::kitchensink_runtime::RuntimeCall;
type BalancesCall = runtime_types::pallet_balances::pallet::Call;

#[subxt_test]
async fn test_sudo() -> Result<(), subxt::Error> {
async fn test_sudo_reports_wrapped_call_failure() -> Result<(), subxt::Error> {
let ctx = test_context().await;
let api = ctx.client();

Expand All @@ -35,14 +35,53 @@ async fn test_sudo() -> Result<(), subxt::Error> {
.create_signed(&tx, &alice, Default::default())
.await?;

let found_event = signed_extrinsic
// The sudo extrinsic itself succeeds, but the wrapped call still needs to
// be inspected via the `Sudid` event. `transfer_allow_death` expects a
// signed origin, so under `Root` we should see the inner call fail.
let sudo_event = signed_extrinsic
.submit_and_watch()
.await?
.wait_for_finalized_success()
.await?
.has::<sudo::events::Sudid>();
.find_first::<sudo::events::Sudid>()?
.expect("Expected sudo::events::Sudid");

assert!(found_event);
assert!(matches!(
sudo_event.sudo_result,
Err(runtime_types::sp_runtime::DispatchError::BadOrigin)
));
Ok(())
}

#[subxt_test]
async fn test_sudo_reports_wrapped_call_success() -> Result<(), subxt::Error> {
let ctx = test_context().await;
let api = ctx.client();

let alice = dev::alice();
let bob = dev::bob().public_key().into();

let call = Call::Balances(BalancesCall::force_set_balance {
who: bob,
new_free: 10_000,
});
let tx = node_runtime::tx().sudo().sudo(call);

let signed_extrinsic = api
.tx()
.await?
.create_signed(&tx, &alice, Default::default())
.await?;

let sudo_event = signed_extrinsic
.submit_and_watch()
.await?
.wait_for_finalized_success()
.await?
.find_first::<sudo::events::Sudid>()?
.expect("Expected sudo::events::Sudid");

assert!(sudo_event.sudo_result.is_ok());
Ok(())
}

Expand All @@ -54,9 +93,9 @@ async fn test_sudo_unchecked_weight() -> Result<(), subxt::Error> {
let alice = dev::alice();
let bob = dev::bob().public_key().into();

let call = Call::Balances(BalancesCall::transfer_allow_death {
dest: bob,
value: 10_000,
let call = Call::Balances(BalancesCall::force_set_balance {
who: bob,
new_free: 10_000,
});
let tx = node_runtime::tx().sudo().sudo_unchecked_weight(
call,
Expand All @@ -72,13 +111,14 @@ async fn test_sudo_unchecked_weight() -> Result<(), subxt::Error> {
.create_signed(&tx, &alice, Default::default())
.await?;

let found_event = signed_extrinsic
let sudo_event = signed_extrinsic
.submit_and_watch()
.await?
.wait_for_finalized_success()
.await?
.has::<sudo::events::Sudid>();
.find_first::<sudo::events::Sudid>()?
.expect("Expected sudo::events::Sudid");

assert!(found_event);
assert!(sudo_event.sudo_result.is_ok());
Ok(())
}