Add sudo examples for inspecting inner call results#2216
Draft
Devpen787 wants to merge 1 commit intoparitytech:masterfrom
Draft
Add sudo examples for inspecting inner call results#2216Devpen787 wants to merge 1 commit intoparitytech:masterfrom
Devpen787 wants to merge 1 commit intoparitytech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sudidresult instead of only checking outer extrinsic successSudidmust be decodedsudoandsudo_unchecked_weightexamples using a root-only balances callWhy
Issue #1854 asks for an example of how to get the result of a wrapped sudo call. The existing tests only proved that the outer sudo extrinsic finalized, which can hide inner-call failure. This patch turns the sudo tests into concrete examples of reading
sudo_resultfrom theSudidevent.Notes
testing/test-runtimerequires a localsubstrateorsubstrate-nodebinary on PATH.cargo fmt --allwas run.Closes #1854