Skip to content

ui: fix filtering for flame chart visualization #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manojVivek merged 6 commits into from
Mar 17, 2026
+15 −3
Merged

ui: fix filtering for flame chart visualization #6228

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
621c92b
ui: fix filtering for flame chart visualization
metalmatze Mar 10, 2026
a766d0f
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Mar 10, 2026
4d906b8
Disable profile filters in flamecharts by default
manojVivek Mar 16, 2026
8eb8c8c
merge origin
manojVivek Mar 16, 2026
145f49b
Merge remote-tracking branch 'origin/main' into worktree-flamechart-f…
manojVivek Mar 16, 2026
1d46c7c
Fix strict-boolean-expressions lint error in VisualisationToolbar
manojVivek Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ui/packages/shared/profile/src/ProfileFlameChart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {TimeUnits, formatDateTimeDownToMS, formatDuration} from '@parca/utilitie
import ProfileFlameGraph, {validateFlameChartQuery} from '../ProfileFlameGraph';
import {boundsFromProfileSource} from '../ProfileFlameGraph/FlameGraphArrow/utils';
import {MergedProfileSource, ProfileSource} from '../ProfileSource';
import {useProfileFilters} from '../ProfileView/components/ProfileFilters/useProfileFilters';
import type {SamplesData} from '../ProfileView/types/visualization';
import {useQuery} from '../useQuery';
import {NumberDuo} from '../utils';
Expand Down Expand Up @@ -128,6 +129,7 @@ export const ProfileFlameChart = ({
onSwitchToOneMinute,
}: ProfileFlameChartProps): JSX.Element => {
const {loader} = useParcaContext();
const {protoFilters} = useProfileFilters();
const zoomControlsRef = useRef<HTMLDivElement>(null);

const [selectedTimeframe, setSelectedTimeframe] = useURLStateCustom<
Expand Down Expand Up @@ -185,6 +187,7 @@ export const ProfileFlameChart = ({
QueryRequest_ReportType.FLAMECHART,
{
skip: selectedTimeframe == null || filteredProfileSource == null,
protoFilters,
}
);

Expand Down
2 changes: 1 addition & 1 deletion ui/packages/shared/profile/src/ProfileView/components/Toolbars/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
const isGraphViz = dashboardItems?.includes('flamegraph');
const isGraphVizOnly = dashboardItems?.length === 1 && isGraphViz;
const isFlamechartViz = dashboardItems?.includes('flamechart');
const isFlamechartVizOnly = dashboardItems?.length === 1 && isFlamechartViz;

Check failure on line 166 in ui/packages/shared/profile/src/ProfileView/components/Toolbars/index.tsx

View workflow job for this annotation

GitHub Actions / UI Test and Lint 

'isFlamechartVizOnly' is assigned a value but never used. Allowed unused vars must match /_/u
Copy link
Contributor

@manojVivek manojVivek Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude remove this unused variable.


const req = profileSource?.QueryRequest();
if (req !== null && req !== undefined) {
Expand Down Expand Up @@ -202,7 +202,7 @@
)}

<div className="flex mt-5">
{!isFlamechartVizOnly && <ProfileFilters />}
<ProfileFilters />

{profileViewExternalSubActions != null ? profileViewExternalSubActions : null}
</div>
Expand Down
Loading